Wrap any 'use strict' files in immediate function. Looks like jQuery is no longer strict mode compliant. Shouldn't matter, because I also removed jQuery to speed page loading. I noticed some files are reported as 0ms load time. I'm wondering if these files were being evaluated 'out of order' by angular. To resolve this possible issue, I load angular-loader at the top of the HTML files. Related to #85, #84, and possible #72, #74
…own regular redirects
Chromium was changed in revision 12d79a to require a user gesture for chrome.management.uninstall. Also indirectly reported in #70 is that all anchor tags on apps page display app.appLaunchUrl appended relatively to New Tab Redirect's extension url. This url doesn't matter because directives pull the evaluated url contents dynamically. I've removed the standard hrefs from rollover icons on an app display, and changed the displayed href for an application's launcher to display the correct target (this follows the mantra of no user surprises). The click event bound to the element actually prevents the default action and allows Chrome to launch the app by id. Doing this allows the extension to launch apps and web pages consistently with little logic on my part. Closes #70
The assumption that the Bookmarks Bar could be found by title breaks when the browser is non-English. I should've known when it was "Bookmarks Bar" in Linux and "Bookmarks bar" in Windows. This change assumes that 'Bookmarks Bar' always has an id of '1'. Closes #60 (at least, I think it does)
Users with special schemes in bookmarks (file://,chrome://,chrome-extension://) can now open these bookmarks from the custom Apps page's bookmarks bar. These special URLs, however, don't support SHIFT+click or CTRL+click like standard anchor tags/links. Closes #47
This is functionality that existed prior to the 3.1 rewrite of options page. A URL must have a scheme, otherwise provide http:// The only scheme supported without :// is about (e.g. about:version). Other schemes exist, but none appear to be supported by chrome.tabs.update. See http://en.wikipedia.org/wiki/URI_scheme Closes #69
It seems half users want cursor in address bar while the other half want it in the page. In an attempt to make debugging user issues with cursor in address bar/in page, I changed to only chrome.tabs.update. In testing, I didn't notice any differences. I believe this is because I tested in Chrome on a profile with a lot of apps/extensions. To give both buckets of users the wanted functionality, I added an update-only option which users can select to enable the new chrome.tabs.update option. This should default to the original behavior for those users who redirect to a search page and expect the cursor focus within the page. Closes #56, #59 Pushing to github so I can test across systems more easily. Should be ready by the end of today.
The initial load for the custom Apps page stopped displaying icons in Chrome 34. The only way to make the icons load is to open a new tab. This commit resolves the issue by wrapping chrome.tabs.duplicate in a service and duplicating/removing the original tab.
…page in the footer of options.html