Rails 4 route mapper compatibility

[nilbus]

Rails no longer supports routes that don't specify an HTTP verb (GET/POST).

See: http://rubysource.com/get-your-app-ready-for-rails-4/
https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/routing/mapper.rb#L62

[jimsynz]

This is great. Do we need to match against the other HTTP verbs though?

[nilbus]

I was wondering that - what do you think? I can't imagine using other verbs to connect from a client, but I figured you would know better. Technically to maintain full backward compatibility, it should include all verbs. How far do you take it? I'm open to your thoughts on this though.

[jimsynz]

See also: https://twitter.com/jamesotron/status/288835511961911296

[nilbus]

On second glance at the Rails 4 code, it looks like you can use match ..., via: :all. And given that post, I think we should. I'll test and modify the pull request.

[jimsynz]

Cool, thanks!

[nilbus]

This works with Rails 4 and matches all HTTP verbs like before. Good catch!

[jimsynz]

Thanks for the PR.

[nilbus]

And you for the quick merge! I'll let you know if I hit any other issues with Rails 4 compatibility.

[aratak]

Guys, am I correctly understand that via: :all doesn't work with old rails?
In such event can we use via: [:get, :post]?

[jimsynz]

This is something we're going to have to fix soon anyway, since we're so close to a Rails 4 release. We're going to need to increase the test coverage a bit so that we can prove that it works on Rails 3.x and Rails 4.

[aaronjensen]

This should be reopened, yea?

[nilbus]

Yes