Skip to content
This repository has been archived by the owner. It is now read-only.

Rails 4 route mapper compatibility #24

Merged
merged 2 commits into from Jan 9, 2013
Merged

Rails 4 route mapper compatibility #24

merged 2 commits into from Jan 9, 2013

Conversation

@nilbus
Copy link
Collaborator

@nilbus nilbus commented Jan 9, 2013

@jimsynz
Copy link
Owner

@jimsynz jimsynz commented Jan 9, 2013

This is great. Do we need to match against the other HTTP verbs though?

@nilbus
Copy link
Collaborator Author

@nilbus nilbus commented Jan 9, 2013

I was wondering that - what do you think? I can't imagine using other verbs to connect from a client, but I figured you would know better. Technically to maintain full backward compatibility, it should include all verbs. How far do you take it? I'm open to your thoughts on this though.

@jimsynz
Copy link
Owner

@jimsynz jimsynz commented Jan 9, 2013

@nilbus
Copy link
Collaborator Author

@nilbus nilbus commented Jan 9, 2013

On second glance at the Rails 4 code, it looks like you can use match ..., via: :all. And given that post, I think we should. I'll test and modify the pull request.

@jimsynz
Copy link
Owner

@jimsynz jimsynz commented Jan 9, 2013

Cool, thanks!

@nilbus
Copy link
Collaborator Author

@nilbus nilbus commented Jan 9, 2013

This works with Rails 4 and matches all HTTP verbs like before. Good catch!

jimsynz pushed a commit that referenced this pull request Jan 9, 2013
James Harton
Rails 4 route mapper compatibility
@jimsynz jimsynz merged commit 7263922 into jimsynz:master Jan 9, 2013
1 check passed
1 check passed
default The Travis build passed
Details
@jimsynz
Copy link
Owner

@jimsynz jimsynz commented Jan 9, 2013

Thanks for the PR.

@nilbus
Copy link
Collaborator Author

@nilbus nilbus commented Jan 9, 2013

And you for the quick merge! I'll let you know if I hit any other issues with Rails 4 compatibility.

jimsynz added a commit that referenced this pull request Feb 5, 2013
… current release. Reopens #24.
@aratak
Copy link

@aratak aratak commented Mar 11, 2013

Guys, am I correctly understand that via: :all doesn't work with old rails?
In such event can we use via: [:get, :post]?

@jimsynz
Copy link
Owner

@jimsynz jimsynz commented Mar 11, 2013

This is something we're going to have to fix soon anyway, since we're so close to a Rails 4 release. We're going to need to increase the test coverage a bit so that we can prove that it works on Rails 3.x and Rails 4.

@aaronjensen
Copy link
Collaborator

@aaronjensen aaronjensen commented Apr 28, 2013

This should be reopened, yea?

@nilbus
Copy link
Collaborator Author

@nilbus nilbus commented Apr 28, 2013

Yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.