Conjured Item Specs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimweirich
added a commit
that referenced
this pull request
Dec 9, 2011
Fix quality adjustment on post sell date conjured items
|
I concur. Good luck with your OK.rb group. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Jim.
I worked your version of the Gilded Rose Kata today. I'm going to use it as an exercise for the OK.rb group tonight. Thanks for preparing this for us.
Anyway, I was butting horns with a couple of your specs and just thought I would mention that I'm not sure I agree with them. Conjured items "degrade in Quality twice as fast as normal items." To me, that means they are -2 before the sell date, but -4 afterward (twice as fast as the normal -2).
I went looking around to see if I could find an official answer to this question. I didn't really. However, at least one other person who has worked with your code agrees with me.
So, this changes the specs if you feel it's warranted.
Thanks again.