Add :phony task #101

Merged
merged 2 commits into from Oct 17, 2012

Conversation

Projects
None yet
3 participants
@jimweirich

This comment has been minimized.

Show comment
Hide comment
@jimweirich

jimweirich Jan 10, 2012

Owner

Example use? Test Cases?

Owner

jimweirich commented Jan 10, 2012

Example use? Test Cases?

@zenspider

This comment has been minimized.

Show comment
Hide comment
@zenspider

zenspider Jan 10, 2012

Contributor

Example use is described in detail in the url above. I'll try to figure out how to test this.

Contributor

zenspider commented Jan 10, 2012

Example use is described in detail in the url above. I'll try to figure out how to test this.

@zenspider

This comment has been minimized.

Show comment
Hide comment
@zenspider

zenspider Jan 10, 2012

Contributor

Test added... I had to dupe the :phony creation inside the test because of helper's setup method...

Contributor

zenspider commented Jan 10, 2012

Test added... I had to dupe the :phony creation inside the test because of helper's setup method...

@damphyr

This comment has been minimized.

Show comment
Hide comment
@damphyr

damphyr Jan 13, 2012

Why not extend the DSL with phony to achieve the same end instead of requiring a => :phony dependency?

So you'd have

phony :isolate => [:whatever]

But I'm still not sure how you use :isolate tbh

damphyr commented Jan 13, 2012

Why not extend the DSL with phony to achieve the same end instead of requiring a => :phony dependency?

So you'd have

phony :isolate => [:whatever]

But I'm still not sure how you use :isolate tbh

@damphyr

This comment has been minimized.

Show comment
Hide comment
@damphyr

damphyr Jan 15, 2012

Maybe this should be Rake::EARLY to be consistent?

Maybe this should be Rake::EARLY to be consistent?

@zenspider

This comment has been minimized.

Show comment
Hide comment
@zenspider

zenspider Jan 15, 2012

Owner

That doesn't make sense. EARLY isn't even a task.

Owner

zenspider commented on e01bb8f Jan 15, 2012

That doesn't make sense. EARLY isn't even a task.

This comment has been minimized.

Show comment
Hide comment
@damphyr

damphyr Jan 16, 2012

Eh, that was a comment in the commit on the code for the timestamp method. Where Time.at 0 it should return Rake::EARLY.
The way it appeared as a comment on the pull request was confusing.

Eh, that was a comment in the commit on the code for the timestamp method. Where Time.at 0 it should return Rake::EARLY.
The way it appeared as a comment on the pull request was confusing.

@zenspider

This comment has been minimized.

Show comment
Hide comment
@zenspider

zenspider May 24, 2012

Contributor

PING

Contributor

zenspider commented May 24, 2012

PING

@zenspider

This comment has been minimized.

Show comment
Hide comment
@zenspider

zenspider May 25, 2012

Contributor

I'm tired of non-communication. I've released this in makerakeworkwell.

Contributor

zenspider commented May 25, 2012

I'm tired of non-communication. I've released this in makerakeworkwell.

@jimweirich jimweirich merged commit b61bbb5 into jimweirich:master Oct 17, 2012

@jimweirich

This comment has been minimized.

Show comment
Hide comment
@jimweirich

jimweirich Oct 17, 2012

Owner

Catching up on the backlog, sorry for the long delay.

Added this as an optional require. Use

require 'rake/phony'

in your Rakefile to enable.

I'm still not sure what value the isolate task provides in your example. If you would care to elucidate, it would be appreciated.

Owner

jimweirich commented Oct 17, 2012

Catching up on the backlog, sorry for the long delay.

Added this as an optional require. Use

require 'rake/phony'

in your Rakefile to enable.

I'm still not sure what value the isolate task provides in your example. If you would care to elucidate, it would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment