Avoid hardcoded newline tests #72

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@luislavena
Contributor

luislavena commented Sep 2, 2011

Add new_line helper to avoid usage of hardcoded newline evaluation in
tests.

Correct tests that presented this issue.

All tests pass:

ruby 1.9.3dev (2011-09-02 revision 33165) [i386-mingw32]
437 tests, 1250 assertions, 0 failures, 0 errors, 0 skips
Avoid hardcoded newline tests
Add `new_line` helper to avoid usage of hardcoded newline evaluation in
tests.

Correct tests that presented this issue.
@rctay

This comment has been minimized.

Show comment Hide comment
@rctay

rctay Nov 27, 2011

Contributor

@nobu Actually, I think we should just strip away the newline character(s) with String.chomp. The tests are not concerned with EOLs.

@luislavena you missed another \n instance just in the next test, test_egrep_with_error.

Contributor

rctay commented Nov 27, 2011

@nobu Actually, I think we should just strip away the newline character(s) with String.chomp. The tests are not concerned with EOLs.

@luislavena you missed another \n instance just in the next test, test_egrep_with_error.

@rctay

This comment has been minimized.

Show comment Hide comment
@rctay

rctay Nov 27, 2011

Contributor

@luislavena here's my take: #90

Contributor

rctay commented Nov 27, 2011

@luislavena here's my take: #90

@rctay

This comment has been minimized.

Show comment Hide comment
@rctay

rctay Dec 6, 2011

Contributor

This should be closed in light of #92.

Contributor

rctay commented Dec 6, 2011

This should be closed in light of #92.

@jimweirich

This comment has been minimized.

Show comment Hide comment
@jimweirich

jimweirich Oct 17, 2012

Owner

egrep no longer opens files in binary mode, so this pull request was closed.

Thanks for the feedback.

Owner

jimweirich commented Oct 17, 2012

egrep no longer opens files in binary mode, so this pull request was closed.

Thanks for the feedback.

@jimweirich jimweirich closed this Oct 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment