Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Changes needed to work with jina 2.0.13 (python 3.9) #692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tommykoctur
Copy link

I have get wikipedia-sentences working with jina 2.0.13. Feel free to edit if you want.

@jakobkruse1
Copy link
Contributor

Thank you for your contribution.
We are currently reworking our examples more generally, we want to update them to use the latest jina version and containerize all executors. We will check if your contribution helps us with that. @nan-wang

@tommykoctur
Copy link
Author

Thank you for the information. I think that in the meantime it could help newbies to run this particular example.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang
Copy link
Member

nan-wang commented Aug 3, 2021

recheckcla

@nan-wang
Copy link
Member

nan-wang commented Aug 3, 2021

Jina CLA check

❤️ Thank you for your pull request. It looks like this is your first contribution to an open source project maintained by Jina AI Limited. Before we can look at your pull request, we kindly ask that you sign our Contributor License Agreement. You can sign it by commenting in format below.


I have read the CLA Document and I hereby sign the CLA


@nan-wang
Copy link
Member

nan-wang commented Aug 3, 2021

hmmm, we can't merge this PR at the current stage because the unit tests failed @tommykoctur

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants