From 62d24c2299c0dae157b914451f588f1fa119c797 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20H=C3=B6nicke?= Date: Wed, 6 Jan 2021 03:59:03 +0100 Subject: [PATCH] refactor: safe comparison None (#1604) --- tests/integration/issues/github_1545/test_executor_metas.py | 2 +- tests/unit/executors/indexers/test_binary_indexer.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/integration/issues/github_1545/test_executor_metas.py b/tests/integration/issues/github_1545/test_executor_metas.py index bc34cdc626b27..cb7c0525e2d30 100644 --- a/tests/integration/issues/github_1545/test_executor_metas.py +++ b/tests/integration/issues/github_1545/test_executor_metas.py @@ -7,6 +7,6 @@ def test_separated_workspace(test_metas): assert not indexer.separated_workspace assert indexer.pea_id == 0 assert indexer.workspace == './' - assert indexer.py_modules == None + assert indexer.py_modules is None assert indexer.pea_workspace == './/None-0' assert indexer.name.startswith('jina.executors.indexers') \ No newline at end of file diff --git a/tests/unit/executors/indexers/test_binary_indexer.py b/tests/unit/executors/indexers/test_binary_indexer.py index a563ef166ffdc..94157a2382bbc 100644 --- a/tests/unit/executors/indexers/test_binary_indexer.py +++ b/tests/unit/executors/indexers/test_binary_indexer.py @@ -14,6 +14,7 @@ @pytest.mark.parametrize('random_workspace_name', ['JINA_TEST_WORKSPACE_BINARY_PB']) def test_binarypb_in_flow(test_metas, mocker): docs = list(random_docs(10)) + def validate(req): mock() assert len(docs) == len(req.docs) @@ -23,7 +24,6 @@ def validate(req): f = Flow(callback_on='body').add(uses='binarypb.yml') - with f: f.index(docs) @@ -117,8 +117,8 @@ def test_binarypb_delete(test_metas): assert idxer.size == 1 with BaseIndexer.load(save_abspath) as idxer: - assert idxer.query(1) == None - assert idxer.query(2) == None + assert idxer.query(1) is None + assert idxer.query(2) is None assert idxer.query(3) == b'random'