Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): update korean readme #1269

Closed
wants to merge 3 commits into from
Closed

Conversation

rabbits99
Copy link

I uploaded again
sorry for make you confused

I uploaded again
sorry for make you confused
@jina-bot jina-bot added size/M area/housekeeping This issue/PR is housekeeping labels Nov 12, 2020

Jina는 Apache License 버전 2.0에 따라 라이센스를 받는다.[전체 라이센스 텍스트는 LICE를 참조하십시오.](LICENSE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to keep this part in original English, at least the Apache License part.

@JoanFM
Copy link
Member

JoanFM commented Nov 12, 2020

Bad commit message, please refer to:

@JoanFM
Copy link
Member

JoanFM commented Nov 12, 2020

recheckcla

@github-actions
Copy link

Jina CLA check

❤️ Thank you for your pull request. It looks like this is your first contribution to an open source project maintained by Jina AI Limited. Before we can look at your pull request, we kindly ask that you sign our Contributor License Agreement. You can sign it by commenting in format below.


I have read the CLA Document and I hereby sign the CLA


@bwanglzu
Copy link
Member

hi @rabbits99 would you like to continue with this PR? it has been 2 weeks. Please check commit guidelines #553 to update your commit message, and sign the CLA.

@rabbits99 rabbits99 changed the title Update README.kr.md fix(readme): update Korean Readme Nov 25, 2020
@rabbits99
Copy link
Author

yes sorry for keeping wait.

this is sign for cla
I have read the CLA Document and I hereby sign the CLA

@rabbits99 rabbits99 changed the title fix(readme): update Korean Readme fix(readme): update korean readme Nov 25, 2020
@bwanglzu
Copy link
Member

@rabbits99 no worries, you need to amend this commit message, otherwise ci will keep failing:
image

sorry for keeping you waiting.
we reupload our file. thank you
@rabbits99
Copy link
Author

we have trouble with amending
so can we create PR again?

@nan-wang
Copy link
Member

we have trouble with amending
so can we create PR again?

Yes, it is easier to create a PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping This issue/PR is housekeeping size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants