-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support provider endpoint in jina executor #6149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6149 +/- ##
==========================================
- Coverage 75.04% 75.02% -0.02%
==========================================
Files 152 152
Lines 14095 14100 +5
==========================================
+ Hits 10577 10578 +1
- Misses 3518 3522 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5a6512d
to
7f19fb3
Compare
deepankarm
reviewed
Mar 7, 2024
JoanFM
requested changes
Mar 7, 2024
37a2fbf
to
fe5932c
Compare
ae7f90f
to
e71c075
Compare
JoanFM
approved these changes
Mar 8, 2024
JoanFM
approved these changes
Mar 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cli
This issue/PR affects the command line interface
area/core
This issue/PR affects the core codebase
area/testing
This issue/PR affects testing
size/M
size/S
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Added
--provider-endpoint
injina executor serve
so that we can specify the endpoint used in SageMaker integration for/invocations
.This is needed for Colbert use case as in the Executor we have multiple endpoints, and each SageMaker model package needs to use different endpoint for
/invocations
from the same Executor container.