Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support provider endpoint in jina executor #6149

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

zac-li
Copy link
Member

@zac-li zac-li commented Mar 7, 2024

Goals

Added --provider-endpoint in jina executor serve so that we can specify the endpoint used in SageMaker integration for /invocations.

This is needed for Colbert use case as in the Executor we have multiple endpoints, and each SageMaker model package needs to use different endpoint for /invocations from the same Executor container.

@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.02%. Comparing base (8a58dfa) to head (14dc3d1).
Report is 3 commits behind head on master.

Files Patch % Lines
jina/serve/executors/__init__.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6149      +/-   ##
==========================================
- Coverage   75.04%   75.02%   -0.02%     
==========================================
  Files         152      152              
  Lines       14095    14100       +5     
==========================================
+ Hits        10577    10578       +1     
- Misses       3518     3522       +4     
Flag Coverage Δ
jina 75.02% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Mar 7, 2024
@zac-li zac-li changed the title [WIP] feat: support provider endpoint in jina executor feat: support provider endpoint in jina executor Mar 7, 2024
@zac-li zac-li marked this pull request as ready for review March 7, 2024 09:20
jina/enums.py Outdated Show resolved Hide resolved
@JoanFM JoanFM closed this Mar 7, 2024
@JoanFM JoanFM reopened this Mar 7, 2024
jina/enums.py Outdated Show resolved Hide resolved
jina/orchestrate/deployments/__init__.py Outdated Show resolved Hide resolved
jina/parsers/orchestrate/pod.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the area/helper This issue/PR affects the helper functionality label Mar 8, 2024
@zac-li zac-li closed this Mar 8, 2024
@zac-li zac-li reopened this Mar 8, 2024
@JoanFM JoanFM merged commit 176f953 into master Mar 8, 2024
129 of 131 checks passed
@JoanFM JoanFM deleted the feat-provider-endppint branch March 8, 2024 08:01
@JoanFM JoanFM mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants