Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipe operator ('|') precedence #47

Closed
flexferrum opened this issue Oct 1, 2018 · 1 comment

Comments

@flexferrum
Copy link
Collaborator

commented Oct 1, 2018

pallets/jinja#882

Current precedence of pipe operator doesn't follow the original jinja2 rules. Need to be fixed. This code:

2 < 6 | bool | string

should be interpreted as:

2 < (6 | bool | string)

instead of

(2 < 6) | bool | string

@flexferrum flexferrum added the bug label Oct 1, 2018

@flexferrum flexferrum added this to To Do in Jinja2Cpp standard features via automation Oct 1, 2018

@flexferrum flexferrum added this to the Release 1.0 milestone Oct 1, 2018

@flexferrum flexferrum moved this from To Do to In Progress in Jinja2Cpp standard features May 29, 2019

palchukovsky added a commit that referenced this issue Jun 12, 2019

palchukovsky added a commit that referenced this issue Jun 13, 2019

flexferrum added a commit that referenced this issue Jun 13, 2019

Bugfix issue 47 (#114)
* Fixed pipe operator ('|') precedence #47

* Removed method FullExpressionEvaluator::SetFilter, as it isn't required anymore after bug #47 resolving.
@flexferrum

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 13, 2019

@flexferrum flexferrum closed this Jun 13, 2019

Jinja2Cpp standard features automation moved this from In Progress to Done Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.