New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark font in status bar #11

Closed
Catscratch opened this Issue Feb 22, 2013 · 10 comments

Comments

Projects
None yet
4 participants
@Catscratch

Catscratch commented Feb 22, 2013

Hi,

the font in the status bar isn't really visible, because it's a dark colored font on a dark background. :-)

Unbenannt

@peterrus

This comment has been minimized.

Show comment
Hide comment
@peterrus

peterrus Mar 6, 2013

I can confirm this (Using Spring Tool Suite, so not pure eclipse)

peterrus commented Mar 6, 2013

I can confirm this (Using Spring Tool Suite, so not pure eclipse)

@jinmingjian

This comment has been minimized.

Show comment
Hide comment
@jinmingjian

jinmingjian Mar 6, 2013

Owner

Sorry, I missed this issue notification in my email box. It is similiar with the issue #5. I give an eye into this problem in these tow days. If it can be reproduced in my windows vm instance, I think it could be fixed soon. thanks!

Owner

jinmingjian commented Mar 6, 2013

Sorry, I missed this issue notification in my email box. It is similiar with the issue #5. I give an eye into this problem in these tow days. If it can be reproduced in my windows vm instance, I think it could be fixed soon. thanks!

@SagaciousZed

This comment has been minimized.

Show comment
Hide comment
@SagaciousZed

SagaciousZed Mar 7, 2013

I can offer proof to you that it is not windows only.
Screen shot 2013-03-07 at 12 12 28 AM

SagaciousZed commented Mar 7, 2013

I can offer proof to you that it is not windows only.
Screen shot 2013-03-07 at 12 12 28 AM

@jinmingjian

This comment has been minimized.

Show comment
Hide comment
@jinmingjian

jinmingjian Mar 7, 2013

Owner

thanks:) they may be another widget used rather than that in issue #5.

Owner

jinmingjian commented Mar 7, 2013

thanks:) they may be another widget used rather than that in issue #5.

@peterrus

This comment has been minimized.

Show comment
Hide comment
@peterrus

peterrus Mar 7, 2013

I am using Ubuntu
On 7 Mar 2013 07:58, "Jin Mingjian" notifications@github.com wrote:

thanks:) they may be another widget used rather than that in issue #5#5
.


Reply to this email directly or view it on GitHubhttps://github.com/jinmingjian/eclipse.themes.darker/issues/11#issuecomment-14545676
.

peterrus commented Mar 7, 2013

I am using Ubuntu
On 7 Mar 2013 07:58, "Jin Mingjian" notifications@github.com wrote:

thanks:) they may be another widget used rather than that in issue #5#5
.


Reply to this email directly or view it on GitHubhttps://github.com/jinmingjian/eclipse.themes.darker/issues/11#issuecomment-14545676
.

@jinmingjian

This comment has been minimized.

Show comment
Hide comment
@jinmingjian

jinmingjian Mar 7, 2013

Owner

OK. I confirm it. The color of the status line(bar) is hard coded. So the style is not used. It needs some hacks. stay tunned.

Owner

jinmingjian commented Mar 7, 2013

OK. I confirm it. The color of the status line(bar) is hard coded. So the style is not used. It needs some hacks. stay tunned.

@jinmingjian

This comment has been minimized.

Show comment
Hide comment
@jinmingjian

jinmingjian Mar 13, 2013

Owner

OSGI Weaving functioanlity will be used for such hacking. And I will adjust the structure of the plugin to separate the UI and non-UI part. My recent time is fragmental... So, sorry for still staying tunned...

Owner

jinmingjian commented Mar 13, 2013

OSGI Weaving functioanlity will be used for such hacking. And I will adjust the structure of the plugin to separate the UI and non-UI part. My recent time is fragmental... So, sorry for still staying tunned...

@jinmingjian

This comment has been minimized.

Show comment
Hide comment
@jinmingjian

jinmingjian Apr 29, 2013

Owner

Hi, all, I roll up my sleeve for this bug today(one day of my vaction). The result is, I'd like to announce the bug has been fixed basically:) And also, I am glad to announce the Darker theme should be the first/only Eclipse 4 theme to solve this kind of annoying SWT styling problem till now(amount of styling problems exist in Eclipse 4, but we may hope it could be fixed in the future). So, very thanks for all of your watching/starring at this plugin! We are on the road!

The process/lesson for the hooking is fun. It is nice to show to the community. So, please wait a little several days for my updating:)

Owner

jinmingjian commented Apr 29, 2013

Hi, all, I roll up my sleeve for this bug today(one day of my vaction). The result is, I'd like to announce the bug has been fixed basically:) And also, I am glad to announce the Darker theme should be the first/only Eclipse 4 theme to solve this kind of annoying SWT styling problem till now(amount of styling problems exist in Eclipse 4, but we may hope it could be fixed in the future). So, very thanks for all of your watching/starring at this plugin! We are on the road!

The process/lesson for the hooking is fun. It is nice to show to the community. So, please wait a little several days for my updating:)

@jinmingjian

This comment has been minimized.

Show comment
Hide comment
@jinmingjian

jinmingjian May 8, 2013

Owner

hi, all, please update your darker plugin in your Eclipse instance: "Help" -> "Install New Software...". I will push the fixing soon if no problem.

Owner

jinmingjian commented May 8, 2013

hi, all, please update your darker plugin in your Eclipse instance: "Help" -> "Install New Software...". I will push the fixing soon if no problem.

@ghost ghost assigned jinmingjian May 8, 2013

@jinmingjian jinmingjian closed this May 9, 2013

@jinmingjian

This comment has been minimized.

Show comment
Hide comment
@jinmingjian

jinmingjian May 20, 2013

Owner

NOTE: the bug fix to the style of statusline is just in recent official Kelper1. Before it being ported to a wide used SRx for Juno(at least several months after Kelper released), the weaving logic should still be kept in the Darker.

Owner

jinmingjian commented May 20, 2013

NOTE: the bug fix to the style of statusline is just in recent official Kelper1. Before it being ported to a wide used SRx for Juno(at least several months after Kelper released), the weaving logic should still be kept in the Darker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment