From 63e0ea0cbfc0e390c0515a12c7c79b4ecb11f89a Mon Sep 17 00:00:00 2001 From: Boris Petrov Date: Thu, 27 Mar 2014 11:19:07 +0200 Subject: [PATCH] Use isModifierKey everywhere --- coffee/frontend/cmds.coffee | 4 ++-- coffee/frontend/modules/get-key.coffee | 2 +- coffee/frontend/modules/key-event.coffee | 2 +- coffee/frontend/modules/search.coffee | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/coffee/frontend/cmds.coffee b/coffee/frontend/cmds.coffee index 6cdb5432..6e1d1f02 100644 --- a/coffee/frontend/cmds.coffee +++ b/coffee/frontend/cmds.coffee @@ -3,8 +3,8 @@ CancelKey = ['', ''] CtrlAcceptKey = [''] CtrlEscapeKey = [''] -window.isControlKey = (key) -> - key in ['Control', 'Shift', 'Alt', 'Win'] +window.isModifierKey = (key) -> + key in ['Control', 'Shift', 'Alt', 'Win', 'Meta'] window.isCtrlAcceptKey = (key) -> key in CtrlAcceptKey diff --git a/coffee/frontend/modules/get-key.coffee b/coffee/frontend/modules/get-key.coffee index 23b2e9b8..a386f697 100644 --- a/coffee/frontend/modules/get-key.coffee +++ b/coffee/frontend/modules/get-key.coffee @@ -114,7 +114,7 @@ specialKeys["F#{key}"] = null for key in [1..12] window.getKey = (evt) -> evt = evt.originalEvent or evt - return evt.keyIdentifier if evt.keyIdentifier in ['Control', 'Alt', 'Meta', 'Shift'] + return evt.keyIdentifier if isModifierKey evt.keyIdentifier key = keyId[evt.keyIdentifier] or evt.keyIdentifier diff --git a/coffee/frontend/modules/key-event.coffee b/coffee/frontend/modules/key-event.coffee index 578cdea8..44541258 100644 --- a/coffee/frontend/modules/key-event.coffee +++ b/coffee/frontend/modules/key-event.coffee @@ -139,7 +139,7 @@ class window.KeyEvent # If Vrome in pass-next or disabled mode and using to enable it. return @enable() if not insertMode and (passNextKey or (disableVrome and isCtrlEscapeKey(key))) - return @stopPropagation e if key in ['Control', 'Alt', 'Shift'] + return @stopPropagation e if isModifierKey key return if disableVrome currentKeys = filterKey currentKeys.concat(key), insertMode diff --git a/coffee/frontend/modules/search.coffee b/coffee/frontend/modules/search.coffee index 1493b849..b251702d 100644 --- a/coffee/frontend/modules/search.coffee +++ b/coffee/frontend/modules/search.coffee @@ -34,7 +34,7 @@ class window.Search handleInput = (e) => return unless searchMode key = getKey e - @removeHighlights() unless key is 'Enter' or isControlKey key + @removeHighlights() unless key is 'Enter' or isModifierKey key lastSearch = text: CmdBox.get().content position: 0