Overriding of default styles (css). #113

Closed
lompy opened this Issue Nov 19, 2012 · 5 comments

Comments

Projects
None yet
4 participants
@lompy

lompy commented Nov 19, 2012

When creating app/assets/stylesheets/monologue/blog/custom.css contents of this file indeed go to the final style sheet, but they appear in the file not in the end. This way custom.css itself is being overrided by defaults. Solved it by changing one line in the gem:

app/assets/stylesheets/monologue/blog/application.css: line 12
        
-        *= require monologue/blog/custom
+        *= include monologue/blog/custom`

I'm using monologue 0.2.0 with rails 3.2.8. But with the proposed solution custom.css appears twice. Something is needed to be done with *= require_tree . in application.css.

@jipiboily

This comment has been minimized.

Show comment Hide comment
@jipiboily

jipiboily Nov 21, 2012

Owner

I guess we could remove the require_tree and require the few files explicitly in the proper order. Would it be possible for you to submit a PR with those changes?

Owner

jipiboily commented Nov 21, 2012

I guess we could remove the require_tree and require the few files explicitly in the proper order. Would it be possible for you to submit a PR with those changes?

@lompy

This comment has been minimized.

Show comment Hide comment
@lompy

lompy Nov 21, 2012

I'm new here, haven't made any commits or PRs yet. I guess I should fork the repo make changes and then request a poll on my changes to merge, right?

lompy commented Nov 21, 2012

I'm new here, haven't made any commits or PRs yet. I guess I should fork the repo make changes and then request a poll on my changes to merge, right?

@msevestre

This comment has been minimized.

Show comment Hide comment
@msevestre

msevestre Nov 21, 2012

Collaborator

Yes that's it. Thanks for helping out!
On Nov 21, 2012 2:26 AM, "Charushin Roman" notifications@github.com wrote:

I'm new here, haven't made any commits or PRs yet. I guess I should fork
the repo make changes and then request a poll on my changes to merge, right?


Reply to this email directly or view it on GitHubhttps://github.com/jipiboily/monologue/issues/113#issuecomment-10587848.

Collaborator

msevestre commented Nov 21, 2012

Yes that's it. Thanks for helping out!
On Nov 21, 2012 2:26 AM, "Charushin Roman" notifications@github.com wrote:

I'm new here, haven't made any commits or PRs yet. I guess I should fork
the repo make changes and then request a poll on my changes to merge, right?


Reply to this email directly or view it on GitHubhttps://github.com/jipiboily/monologue/issues/113#issuecomment-10587848.

@msevestre msevestre referenced this issue Dec 1, 2012

Merged

Header cleanup #117

@jipiboily

This comment has been minimized.

Show comment Hide comment
@jipiboily

jipiboily Dec 2, 2012

Owner

Thanks @msevestre for the PR and @lompy for reporting. I'll merge #117 and that'll be fixed.

Owner

jipiboily commented Dec 2, 2012

Thanks @msevestre for the PR and @lompy for reporting. I'll merge #117 and that'll be fixed.

@jipiboily jipiboily closed this Dec 2, 2012

@kacyhulme

This comment has been minimized.

Show comment Hide comment
@kacyhulme

kacyhulme Mar 26, 2015

I added a custom.css file inside app/assets/stylesheets/monologue/blog and it works perfectly in development. But changes are not showing in production. Anything else I need to do other than add the custom.css file? Should I copy over Monologue's application.css?

I added a custom.css file inside app/assets/stylesheets/monologue/blog and it works perfectly in development. But changes are not showing in production. Anything else I need to do other than add the custom.css file? Should I copy over Monologue's application.css?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment