Bug in the admin when a comma was at the end of the tag list #104

Merged
merged 1 commit into from Oct 2, 2012

Conversation

Projects
None yet
2 participants
Collaborator

msevestre commented Oct 2, 2012

Bugs corrected when a comma was at the end if the tag list such as Tag1, Tag2,

@jipiboily jipiboily added a commit that referenced this pull request Oct 2, 2012

@jipiboily jipiboily Merge pull request #104 from msevestre/master
Bug in the admin when a comma was at the end of the tag list
6b8a6d7

@jipiboily jipiboily merged commit 6b8a6d7 into jipiboily:master Oct 2, 2012

1 check passed

default The Travis build passed
Details
Owner

jipiboily commented Oct 2, 2012

thanks!

Owner

jipiboily commented Oct 2, 2012

oh, would you mind writing a test for that? Like writing a test of how to reproduce the bug you were facing? That would be awesome and would make sure there is no regression in the future.

Collaborator

msevestre commented Oct 2, 2012

Test suite does work locally since i have updated to webkit. No time to
invest in that right now
On Oct 1, 2012 8:44 PM, "Jean-Philippe Boily" notifications@github.com
wrote:

oh, would you mind writing a test for that? Like writing a test of how to
reproduce the bug you were facing? That would be awesome and would make
sure there is no regression in the future.


Reply to this email directly or view it on GitHubhttps://github.com/jipiboily/monologue/pull/104#issuecomment-9055413.

Collaborator

msevestre commented Oct 2, 2012

Might be able to get to that tomorrow
On Oct 1, 2012 8:52 PM, "Michael Sevestre" michael.sevestre@gmail.com
wrote:

Test suite does work locally since i have updated to webkit. No time to
invest in that right now
On Oct 1, 2012 8:44 PM, "Jean-Philippe Boily" notifications@github.com
wrote:

oh, would you mind writing a test for that? Like writing a test of how to
reproduce the bug you were facing? That would be awesome and would make
sure there is no regression in the future.


Reply to this email directly or view it on GitHubhttps://github.com/jipiboily/monologue/pull/104#issuecomment-9055413.

Owner

jipiboily commented Oct 2, 2012

If you don't have time, nevermind, I can take a look at that. Thanks you for all your hard work, appreciate it!

Collaborator

msevestre commented Oct 2, 2012

No my bad. I should always write tests. I ll let you know when it s ready
On Oct 1, 2012 8:59 PM, "Jean-Philippe Boily" notifications@github.com
wrote:

If you don't have time, nevermind, I can take a look at that. Thanks you
for all your hard work, appreciate it!


Reply to this email directly or view it on GitHubhttps://github.com/jipiboily/monologue/pull/104#issuecomment-9055684.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment