Added romanian translation #109

Merged
merged 2 commits into from Oct 17, 2012

Projects

None yet

2 participants

@chalmagean
Contributor

No description provided.

@jipiboily
Owner

@mixandgo thanks for the PR! Awesome to have another locale! :)

On the other hand, could you remove the last commit please and do a separate PR for that. I'll have to double check what is the most semantic way to add a header in a footer but I am almost certain it won't be a div, no offense!

Thanks!

PS: are you using Monologue in production yet? If you are, please add it here, if you want: https://github.com/jipiboily/monologue/wiki/Sites-running-Monologue.

@chalmagean
Contributor

I've removed the footer commit.

I am gonna use monologue in production, I'm in the process of writing my first blog post.

@jipiboily jipiboily merged commit 0431a2c into jipiboily:master Oct 17, 2012

1 check passed

default The Travis build passed
Details
@jipiboily
Owner

Thanks for the PR! Are you using gem version 0.2.0.beta3 currently?

@chalmagean
Contributor

Actually I am using my fork (which is a fork from master) cause I need the h1 removed from the footer, and also I need a convert_urls : false in tinymce-config.js. I would be nice to be able to customize tinymce from the main app.

@jipiboily
Owner

You know you can just overwrite those file at the exact same path in your app and use the gem (or the "official" git repo)? Only those will be overridden! :)

@chalmagean
Contributor

I did try that but for some reason it didn't work.

@jipiboily
Owner

It should work, this is something I used a lot for multiple engines, including Monologue.

If you want to override the tinymce config, you should have the file exactly at app/assets/javascripts/monologue/admin/tinymce-config.js in your app, including the /monologue part of it. Is that what you tried?

If no, what version of Rails are you using?

@chalmagean
Contributor

I'm on rails 3.2.8 and I've double checked the path. Still it doesn't work.

@jipiboily
Owner

Just to let you know, I changed the h1 in the footer tag for a span, it is on master. Will release stable version soon.

@jipiboily
Owner

If you can provide me with a failing override in a dummy project, I would be glad to help you. I can't reproduce you're issue, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment