Header cleanup #117

Merged
merged 4 commits into from Dec 4, 2012

Projects

None yet

4 participants

@msevestre
Collaborator

Here we go: A little PR cleaning up some stuff mentioned in #114 and #115
I also did #113 because I need it badly for one project

Let's discuss the changes if you wish

@msevestre msevestre and 2 others commented on an outdated diff Dec 1, 2012
app/views/monologue/posts/_revision_header.html.erb
@@ -1,9 +1,14 @@
<header class="revision-header">
<h1><%= link_to revision.title, revision.full_url %></h1>
- <div class="posted">
- <time datetime="<%= revision.published_at %>">
- <%= I18n.localize(revision.published_at.to_date, :format => :long) %>
- </time>
- &nbsp;&nbsp;|&nbsp;&nbsp;<%= revision.user.name %>&nbsp;&nbsp;|&nbsp;&nbsp;<a href="<%= revision.full_url + "#disqus_thread" %>"></a>
- </div>
-</header>
+ <span data-monologue="time">
@msevestre
msevestre Dec 1, 2012

I removed the div class="posted" because it's not needed. Let me know if there is a need for that and I can put it back in

@jipiboily
jipiboily Dec 2, 2012

Seems like it is used in CSS here: https://github.com/jipiboily/monologue/blob/master/app/assets/stylesheets/monologue/blog/monologue.css#L86

Maybe you just change that to reflect the new structure?

@msevestre
msevestre Dec 2, 2012

yeah it's not really used I think. The size for instance (12) is not valid as well. It should read 12px.

@msevestre
msevestre Dec 2, 2012

But I might put it back in anyways so he does not break style from people using it.

@iwada
iwada Dec 2, 2012
@msevestre
msevestre Dec 2, 2012

@iwada : What did you want to point out?

@msevestre
Collaborator

not sure why the build is broken...i suspect a travis bug...I'll check it tomorrow

@jipiboily
Owner

Agree about the broken build, looks like a Travis bug.

@msevestre
Collaborator

Are you going to merge that PR or should I do the sass clean up first? Waiting for your instructions...

@jipiboily jipiboily merged commit 4a353d4 into jipiboily:master Dec 4, 2012

1 check passed

Details default The Travis build passed
@jipiboily
Owner

Thanks @msevestre !

@lightswitch05

Thank you for removing the duplicate ids! I had a minor OCD attack when I saw that in the current version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment