New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to show annotations on demand #535

Open
mwean opened this Issue Feb 6, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@mwean
Copy link

mwean commented Feb 6, 2019

Description

I would like the annotation feature exposed as a command so it can be shown on-demand with a shortcut. I don't like having it on all the time because it's distracting most of the time, but I'd like to be able to blame a line (or multiple?) with a shortcut. It seems like we could just update run_blame to have an argument that would bypass the git_gutter.line_annotation.is_enabled() check. Does that sound reasonable?

@deathaxe deathaxe added the enhancement label Feb 6, 2019

@deathaxe

This comment has been minimized.

Copy link
Collaborator

deathaxe commented Feb 6, 2019

The run_blame basically was intended to be used as command. Binding it to the settings, which are needed for the event handling is actually an oversight. It should work the same way as the show_diff_popup.

Don't think it makes much sense to run blame on multiple lines at a time. Handling that would need much more effort to parse git's results. Displaying tons of blame messages at the end of a line would be confusing anyway. The annotation is just meant for a quick info. For anything else GitSavvy's blame or Sublime Merge's blame function are much more suitable.

@AmjadHD

This comment has been minimized.

Copy link

AmjadHD commented Feb 7, 2019

is there currently a way to disable icons, but not diff popups ?

@deathaxe

This comment has been minimized.

Copy link
Collaborator

deathaxe commented Feb 7, 2019

A first step was taken in the most recent commit on master, but it does work properly with Compare Against HEAD at the moment. Need to make use of ST's set_reference_document() API to keep the mini diff in sync if an older revision is selected via Compare Against....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment