Reduce memory usage of ExportToFile#7
Merged
jitbit merged 5 commits intojitbit:masterfrom Feb 24, 2016
c-w:master
Merged
Conversation
Using `File.WriteAllText` and `Export` builds the entire CSV string and then writes it to disk. This essentially doubles the peak memory usage of the class and is impractical for larger CSV documents. Using `File.WriteAllLines` and `ExportToLines` on the other hand only keeps a single row in memory at a time.
jitbit
pushed a commit
that referenced
this pull request
Feb 24, 2016
Reduce memory usage of ExportToFile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
ExportToFileuses a lot of memory for large CSV files because it builds the entire document in memory. This pull request uses a streaming approach to reduce the memory overhead to a constant.Testing:
old.csvnew.csvold.csvandnew.csv