Added on-click callback feature #38

Charnelx · 2018-08-19T07:07:38Z

Hi.
I added callback on click functionality discussed in this issue .
Implementation followed this comment plus my own code snippet for decorator/handler.

How it works - just add to show_toast method argument called callback_on_click with callable as value.

teltmau5 · 2018-08-20T06:24:09Z

Great, this works perfectly for me!

JDogg1329 · 2018-08-26T11:50:01Z

Is this going to be merged?

@Charnelx could you give a bit more detail on this, sorry guys bit of a Python noob, I downloaded the changed file and replaced the old one in source, built from source (I think that worked correctly?) Just need some clarification on how to implement a click action to my toast notifications

Charnelx · 2018-08-26T18:26:55Z

@JDogg1329 , don't know about merge, but you can get this from my own repo if needed.
On-click implementation is really easy - just pass callable (in this case function that doesn't receive any arguments) as value of show_toast method parameter called callback_on_click.

Example:

def say_hello():
    print('Hello!')

toast = ToastNotifier()
toast.show_toast( title="Notification", msg="Here comes the message",
                    icon_path=None, duration=5, threaded=False, callback_on_click=say_hello)

In this case, if notification is clicked, say_hello function will be called.

JDogg1329 · 2018-08-27T05:29:01Z

Thanks @Charnelx ! So is it possible to pass an argument to the callback_on_click method?

Charnelx · 2018-08-29T18:47:44Z

@JDogg1329 , nope, you can't pass the argument in a direct way...but you can do a trick like this:

toast.show_toast( title="Notification", msg="Here comes the message",
                    icon_path=None, duration=5, threaded=False, callback_on_click=lambda: say_hello(arg))

vineethpisvas1 · 2018-11-30T08:57:52Z

@Charnelx Bro I have been trying some random stuff for a long time. Thanks for your help. Now I can die peacefully 🤣

zvibazak · 2019-03-11T13:59:27Z

@Charnelx I noticed that if user won't click on the notification, after 10 seconds (in windows 10) the message will be moved to "Action Center" (the notification area on the left side of the screen), and there I couldn't handle the user's click action.
Do you have any idea?
I want a web page to be opened when user click on the notification.

Thanks

Enhancement of Added on-click callback feature jithurjacob#38. New code now supports parameters to be passed to callback function. Issue: When including parameters to callback function, the function gets executed before the notification. The intention of the on-click was to wait for user click the notification before execute the function def say_hello(): print('Hello!') toast = ToastNotifier() toast.show_toast( title="Notification", msg="Here comes the message", icon_path=None, duration=5, threaded=False, callback_on_click=say_hello(param)) With new code: def say_hello(**kwargs): print(kwargs.get('func_param1 ') + kwargs.get('func_param2 ')) toast = ToastNotifier() toast.show_toast( title="Notification", msg="Here comes the message", icon_path=None, duration=5, threaded=False, callback_on_click=say_hello, func_param1 = 'Hello', func_param2 = 'World' )

hwsamuel · 2019-04-28T20:13:30Z

I've installed win10toast via pip and it seems that's not the latest code version because the callback_on_click argument doesn't work. Error says "TypeError: show_toast() got an unexpected keyword argument 'callback_on_click'"

umutinevi · 2019-06-20T18:07:33Z

I've installed win10toast via pip and it seems that's not the latest code version because the callback_on_click argument doesn't work. Error says "TypeError: show_toast() got an unexpected keyword argument 'callback_on_click'"

same for me.

Fixes incompatibility with pip version 10 and above

ghost · 2019-08-19T02:17:27Z

Does this still work? I tried replacing my init.py contents with the contents from your file @Charnelx but the script was full of errors and said the callback_on_click was not an argument I could use. Sorry if I am doing something wrong, but I'm a noob

Charnelx · 2019-08-21T20:27:57Z

@crappy-coder21 , just try to update your version using pip.

LeNarvalo · 2019-11-07T13:23:37Z

@Charnelx Nice work !
Are there any way to get win32con.WM_RBUTTONUP in lparam for example ?

Zhell1 · 2019-12-19T02:50:49Z

this should be merged to master it is a very useful feature

MPeek1995 · 2020-03-11T18:39:21Z

Anybody still having problems with the:
TypeError: show_toast() got an unexpected keyword argument 'callback_on_click'
I keep getting this message.

I installed yesterday so it must be the latest version.

What could i do wrong?

VerifyBot · 2020-05-04T14:12:56Z

Was it fixed? Because I still get the error TypeError: show_toast() got an unexpected keyword argument 'callback_on_click'

now uses release from this pull request of win10toast: jithurjacob/Windows-10-Toast-Notifications#38

JakubBlaha · 2020-05-23T08:55:51Z

Will this ever be merged? Because I hope so.

JakubBlaha · 2020-05-23T09:16:34Z

If anyone want's this feature and is using pipenv, the following command will update the package to the version with the callback_on_click parameter.

pipenv install git+https://github.com/Charnelx/Windows-10-Toast-Notifications.git#egg=win10toast

I couldn't get it to work using pip.

aleanun89 · 2020-06-02T13:57:07Z

LGTM

sercanyilmaz84 · 2020-07-23T11:35:45Z

There is still same problem:

TypeError: show_toast() got an unexpected keyword argument 'callback_on_click'

malun22 · 2020-10-21T15:02:08Z

Here is the init: https://stackoverflow.com/questions/62828043/how-to-perform-a-function-when-toast-notification-is-clicked-in-python

frak0d · 2020-12-07T03:08:09Z

Is it ever going to merge ?
Or is @jacobcolbert dead due to corona ?

Its been 2 Years Now !

@Charnelx Please make a New pip Repo with Your Version 🙏

leon-mueller · 2020-12-09T11:15:46Z

Hey Guys,

this works perfectly, BUT:

in my case the callback_on_click is executed instantly after this toast shows up.

How can i make that the action only executes if I click it?

cheers leon

jakubblaha-ids · 2020-12-09T11:19:21Z

@leon-mueller

You are probably doing something like

...(callback_on_click=print('clicked'))

when in reality, you wanna do

...(callback_on_click=lambda: print('clicked'))

leon-mueller · 2020-12-09T12:29:22Z

@jakubblaha-ids

I'm doing as followed:

... callback_on_click=open_ticket(ticket_link)

def open_ticket(url):
webbrowser.open(url)

In this case it's always executing the def open_ticket when the toast shows up

JakubBlaha · 2020-12-09T13:58:16Z

@leon-mueller

What you are doing is essentially the same as...

result = open_ticket(ticket_link)
...(click_on_callback=result)

You are calling the function and assigning it's return value to the click_on_callback parameter.

You instead need to pass in the function (not it's call resulting in a return value) as the click_on_callback argument. This can be done by defining a function without a name using the lambda keyword (you can google that) as follows.

...(callback_on_click=lambda: open_ticket(ticket_link))

leon-mueller · 2020-12-09T14:18:04Z

@JakubBlaha

aaaah damn didn't thought about that tho.
Thank you very much!!!!

jellytoaster · 2021-01-25T00:18:16Z

i feel dumb, but how do i install it????

JakubBlaha · 2021-01-25T08:19:43Z

@jellytoaster
#38 (comment)

jellytoaster · 2021-01-25T13:46:49Z

@jellytoaster
#38 (comment)
thx

jellytoaster · 2021-01-25T13:53:10Z

help, im getting errors saying "the system could not find the file specified."
do i need anaconda or something????

JakubBlaha · 2021-01-27T08:11:01Z

@jellytoaster With this little information noone can help you. You will better off to ask on StackOverflow. GitHub issues is not a place to ask such questions.

ZhangTianrong · 2021-01-31T06:24:47Z

If anyone want's this feature and is using pipenv, the following command will update the package to the version with the callback_on_click parameter.
pipenv install git+https://github.com/Charnelx/Windows-10-Toast-Notifications.git#egg=win10toast
I couldn't get it to work using pip.

If you don't use pipenv, you can clone the repo and install through python .\setup.py install. If there is error, change attrgetter("req") in line 21 of setup.py to attrgetter("requirement") as indicated here.

Ariel-MN · 2021-03-13T09:06:27Z

Is there a fork that allows using duration = False?

coredev-uk · 2021-03-26T16:35:19Z

Is there a fork that allows using duration = False?

If you're aiming to keep the notification persistent in the action centre duration=None works if that's what you're going at having it false.

dariopnc · 2021-04-02T08:57:33Z

Is it ever going to merge ?
Or is @jacobcolbert dead due to corona ?

Its been 2 Years Now !

@Charnelx Please make a New pip Repo with Your Version 🙏

I suppose you meant @jithurjacob instead of @jacobcolbert

frak0d · 2021-04-02T15:13:55Z

I suppose you meant @jithurjacob instead of @jacobcolbert

i believe he changed his name

TidosDK

Love it

leolencelAI · 2021-04-21T15:28:46Z

I've a problem, I ran this code but the function trigger as soon as the toast appear on the screen. So click don't work. Do you have the same problem? (I would like to open a webpage whether I click on the toast)

ZhangTianrong · 2021-04-21T15:52:57Z

I've a problem, I ran this code but the function trigger as soon as the toast appear on the screen. So click don't work. Do you have the same problem? (I would like to open a webpage whether I click on the toast)

That's because you used a function call as the trigger instead of the function itself.

Fakeaccount12312 · 2021-04-28T23:54:17Z

@Charnelx I noticed that if user won't click on the notification, after 10 seconds (in windows 10) the message will be moved to "Action Center" (the notification area on the left side of the screen), and there I couldn't handle the user's click action.
Do you have any idea?

ZLB08 · 2021-07-06T16:24:47Z

The library works well for me except on one point: I want my notification to stay in the action center if I don't click on it. So I set the duration parameter to None. However, after 10s, the notification disappear from the action center.

It is strange because this functionality works well on the previous version (win10toast_persist). Does anyone had the same issue already ?

dmtzs · 2022-04-25T13:32:38Z

This pull request will be merged and able when you do your pip install someday?

Added on-click callback feature

2aa1b9d

Charnelx mentioned this pull request Aug 19, 2018

Go to application on click? #3

Open

Show constant toast if duration is None;

559baf9

kykezyz mentioned this pull request Mar 30, 2019

Added on-click callback-parameters kykezyz/Windows-10-Toast-Notifications#1

Merged

thrashbun and others added 6 commits July 12, 2019 18:30

Update setup.py

71faebd

Update setup.py

5df30de

jithurjacob#33 added logging to classAtom

f7f801d

Fix merging bug

8fc868e

Merge https://github.com/Berailitz/Windows-10-Toast-Notifications

b5e05ab

Merge pull request #1 from jacobcolbert/master

98b894b

Fixes incompatibility with pip version 10 and above

GEOFAIRY pushed a commit to GEOFAIRY/Seek-Job-Scraper that referenced this pull request May 22, 2020

updated how toast notifications work

4954b71

now uses release from this pull request of win10toast: jithurjacob/Windows-10-Toast-Notifications#38

TidosDK reviewed Apr 20, 2021

View reviewed changes

HarryPeach mentioned this pull request Sep 23, 2022

Add on-click callback feature HarryPeach/WindowsRichNotifications#2

Closed

Added on-click callback feature #38

Are you sure you want to change the base?

Added on-click callback feature #38

Conversation

Charnelx commented Aug 19, 2018 • edited Loading

teltmau5 commented Aug 20, 2018

JDogg1329 commented Aug 26, 2018

Charnelx commented Aug 26, 2018 • edited Loading

JDogg1329 commented Aug 27, 2018

Charnelx commented Aug 29, 2018

vineethpisvas1 commented Nov 30, 2018

zvibazak commented Mar 11, 2019 • edited Loading

hwsamuel commented Apr 28, 2019

umutinevi commented Jun 20, 2019

ghost commented Aug 19, 2019

Charnelx commented Aug 21, 2019

LeNarvalo commented Nov 7, 2019

Zhell1 commented Dec 19, 2019 • edited Loading

MPeek1995 commented Mar 11, 2020 • edited Loading

VerifyBot commented May 4, 2020

JakubBlaha commented May 23, 2020

JakubBlaha commented May 23, 2020

aleanun89 commented Jun 2, 2020

sercanyilmaz84 commented Jul 23, 2020

malun22 commented Oct 21, 2020

frak0d commented Dec 7, 2020

leon-mueller commented Dec 9, 2020

jakubblaha-ids commented Dec 9, 2020

leon-mueller commented Dec 9, 2020

JakubBlaha commented Dec 9, 2020

leon-mueller commented Dec 9, 2020

jellytoaster commented Jan 25, 2021

JakubBlaha commented Jan 25, 2021

jellytoaster commented Jan 25, 2021

jellytoaster commented Jan 25, 2021

JakubBlaha commented Jan 27, 2021

ZhangTianrong commented Jan 31, 2021

Ariel-MN commented Mar 13, 2021

coredev-uk commented Mar 26, 2021

dariopnc commented Apr 2, 2021

frak0d commented Apr 2, 2021

TidosDK left a comment • edited Loading

Choose a reason for hiding this comment

leolencelAI commented Apr 21, 2021

ZhangTianrong commented Apr 21, 2021

Fakeaccount12312 commented Apr 28, 2021

ZLB08 commented Jul 6, 2021 • edited Loading

dmtzs commented Apr 25, 2022 • edited Loading

Charnelx commented Aug 19, 2018 •

edited

Loading

Charnelx commented Aug 26, 2018 •

edited

Loading

zvibazak commented Mar 11, 2019 •

edited

Loading

Zhell1 commented Dec 19, 2019 •

edited

Loading

MPeek1995 commented Mar 11, 2020 •

edited

Loading

TidosDK left a comment •

edited

Loading

ZLB08 commented Jul 6, 2021 •

edited

Loading

dmtzs commented Apr 25, 2022 •

edited

Loading