Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #5

Merged
merged 14 commits into from Dec 6, 2020
Merged

GitHub actions #5

merged 14 commits into from Dec 6, 2020

Conversation

ch8n
Copy link

@ch8n ch8n commented Oct 4, 2020

hi @jitinsharma
I have added GitHub action CI on the creation of new PR and when there is a new Push on the master branch

I have also updated dependencies, without updating dependencies build wasn't passing.
please do the code review
looking forward to your reply
Thanks
Regards,
Chetan Gupta

@ch8n
Copy link
Author

ch8n commented Oct 4, 2020

hi @jitinsharma
I have added GitHub action CI on the creation of new PR and when there is a new Push on the master branch

I have also updated dependencies, without updating dependencies build wasn't passing.
please do the code review
looking forward to your reply
Thanks
Regards,
Chetan Gupta

IMPORTANT
Hi, Hacktober fest guidelines have been updated please mark it with the tag so I can earn a PR.
https://hacktoberfest.digitalocean.com/hacktoberfest-update

@ch8n ch8n changed the title GitHub actions GitHub actions [Please dont merge without Hacktober fest tag] Oct 4, 2020
@jitinsharma
Copy link
Owner

@ch8n Why didn't github action run on this PR?

@jitinsharma jitinsharma linked an issue Oct 5, 2020 that may be closed by this pull request
@ch8n
Copy link
Author

ch8n commented Oct 5, 2020

Hi @jitinsharma you need to first merge this to enable that, you need to have yml files in your codebase to start action triggers

@ch8n ch8n changed the title GitHub actions [Please dont merge without Hacktober fest tag] GitHub actions Oct 5, 2020
@jitinsharma jitinsharma merged commit 5a6eb2f into jitinsharma:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up CI with github actions
2 participants