Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relayId coming as 0.0.0.0 from after stable-7287-2 jvb images #1349

Closed
shuhaib3 opened this issue Jul 22, 2022 · 11 comments
Closed

relayId coming as 0.0.0.0 from after stable-7287-2 jvb images #1349

shuhaib3 opened this issue Jul 22, 2022 · 11 comments

Comments

@shuhaib3
Copy link

Hi @saghul ,

After jvb release 7287-2 ie, in stable-7439 and stable-7439-2. the relayid shown in jicofo logs is as 0.0.0.0.
image
I think the relay id is being picked up from here in the last two releases.
when I change the bind address the relay id in jicofo is changing.
Any way to change the relayid to JVB_OCTO_PUBLIC_ADDRESS?

@saghul
Copy link
Member

saghul commented Jul 22, 2022

I honestly have no idea :-/ @bgrozev can you enlighten us here?

@shuhaib3
Copy link
Author

@bgrozev is this might be the issue
jitsi/jitsi-videobridge@26085c6

@shuhaib3
Copy link
Author

@bgrozev even if relayid is there it is getting a fallback to bind address

@bgrozev
Copy link
Member

bgrozev commented Jul 22, 2022

Sorry, I'm not sure what breaks, but it's best to simply update to the latest config scheme. Something like:

{{ if $ENABLE_OCTO -}}
relay {
  enabled = true
  relay-id="<RELAY-ID>"
  region = "{{ .Env.JVB_OCTO_REGION | default "europe" }}"
}
{{ end -}}

I'm not sure what the best way to set the ID in a docker setup is. It just needs to be unique in the set of jvb's connected to jicofo. Taking $JVB_MUC_NICKNAME might work, or whatever was used to set bind-address.

We can get rid of .Env.JVB_OCTO_BIND_ADDRESS, .Env.JVB_OCTO_PUBLIC_ADDRESS, and .Env.JVB_OCTO_BIND_PORT.

@shuhaib3
Copy link
Author

image
ok, but here what is happening is that in last two releases the bind address is taken as relayid. hence the default value is 0.0.0.0 it is not getting unique. previously it used to take the relay id from public-address = "{{ .Env.JVB_OCTO_PUBLIC_ADDRESS }}"
@saghul do we need a change here
https://github.com/jitsi/docker-jitsi-meet/blob/master/jvb/rootfs/defaults/jvb.conf

@saghul
Copy link
Member

saghul commented Jul 24, 2022

Sorry, I'm not sure what breaks, but it's best to simply update to the latest config scheme. Something like:


{{ if $ENABLE_OCTO -}}

relay {

  enabled = true

  relay-id="<RELAY-ID>"

  region = "{{ .Env.JVB_OCTO_REGION | default "europe" }}"

}

{{ end -}}

I'm not sure what the best way to set the ID in a docker setup is. It just needs to be unique in the set of jvb's connected to jicofo. Taking $JVB_MUC_NICKNAME might work, or whatever was used to set bind-address.

We can get rid of .Env.JVB_OCTO_BIND_ADDRESS, .Env.JVB_OCTO_PUBLIC_ADDRESS, and .Env.JVB_OCTO_BIND_PORT.

Thanks I'll update the config!

@saghul
Copy link
Member

saghul commented Aug 18, 2022

Continues on #1371

@saghul saghul closed this as completed Aug 18, 2022
@shuhaib3
Copy link
Author

@saghul relay id is still coming as 0.0.0.0 in latest jitsi/jvb:stable-7648-4 image
version=2.2.22-g42bc1b99, relayId=0.0.0.0, region=europe, stress=0.01] with stress=0.01358 for participantRegion=ap-south-1

@saghul
Copy link
Member

saghul commented Sep 15, 2022

Did you set JVB_OCTO_RELAY_ID ?

@yoerayo
Copy link

yoerayo commented Sep 15, 2022

@shuhaib3 @saghul I don't believe these changes are included in any releases yet, I had to manually apply them for my deployment.

@saghul
Copy link
Member

saghul commented Sep 15, 2022

Right, my bad! I just noticed the PR is not merged, I'll do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants