Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload I/O from ScheduledExecutorService thread in PaceMaker. #173

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@mstyura
Copy link
Contributor

mstyura commented Feb 12, 2019

TL; DR:
Fixed thread starvation in PaceMaker due to operation with blocking I/O executed on ScheduledExecutorService's thread which was introduced #152.

Problem:
It was reported by Jitsi Team, that changes introduced in PR #151, #152, #153, #155 introduced regression on TCP, when there is a thread starvation caused by blocking I/O executed on fixed-size thread pool.

Solution:
Split scheduling (delayed execution) from actual execution into different pools: use ScheduledExecutorService as a "timer" and cached thread pool for actual task execution. So when some of executed tasks blocked on I/O or something else, it should not prevent scheduling from work and should not affect other tasks.

@bgrozev bgrozev merged commit 80471b7 into jitsi:master Feb 13, 2019

1 check passed

default 502 tests run, 370 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.