Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
use the jitsi-utils logger #186
There are 2 main questions here: one is the the log context and the other is the enforcement of the minimum log level from the top down. The log context stuff slf4j does have support for and making it work with java.util.logger it looks like it should be doable? But I haven't taken a look at it. The other feature is kinda unique and I'm not sure if slf4j supports it (basically we need to enforce that a parent logger and all of its children don't log messages below a certain level, even if they are configured to).
If you've got any insight on those I'd be interested to hear it. I'll admit, though, that the main reason I didn't change to slf4j or dig too deeply into whether or not it supports these things is that, as big as these changes may seem, they're still entirely superficial and I didn't want to (lazy?) get into the work of validating a change of logging framework.
so i think it may be impossible to get the tests passing here. jicofo fails to build because it relies on the bridge, but we can't update the bridge dependency because we don't have one until we have an ice4j version...which we won't get until this PR merges :)