New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sends json-messages for translations & Sets the participant translation language on presence update #124

Merged
merged 13 commits into from Jul 24, 2018

Conversation

Projects
None yet
3 participants
@pvgupta24
Contributor

pvgupta24 commented Jul 12, 2018

Depends on

  • jitsi/jitsi#504 for presence extension. pom.xml to be updated with the new jitsi-dektop-version

Can be tested by dialing the transcriber and setting the language from console :
APP.conference._room.setLocalParticipantProperty('translation_language','hi');

@pvgupta24 pvgupta24 changed the title from WIP : Sets the participant translation language on presence update of member to Sets the participant translation language on presence update of member Jul 18, 2018

@pvgupta24 pvgupta24 changed the title from Sets the participant translation language on presence update of member to Sends json-messages for translations & Sets the participant translation language on presence update Jul 19, 2018

Show outdated Hide outdated src/main/java/org/jitsi/jigasi/AbstractGatewaySession.java
Show outdated Hide outdated src/main/java/org/jitsi/jigasi/TranscriptionGatewaySession.java
Show outdated Hide outdated src/main/java/org/jitsi/jigasi/TranscriptionGatewaySession.java
Show outdated Hide outdated src/main/java/org/jitsi/jigasi/transcription/Transcriber.java
*/
@Override
public void publish(ChatRoom chatRoom, TranslationResult result)
{

This comment has been minimized.

@nikvaessen

nikvaessen Jul 20, 2018

Contributor

maybe add a comment why we leave this empty

@nikvaessen

nikvaessen Jul 20, 2018

Contributor

maybe add a comment why we leave this empty

Show outdated Hide outdated src/main/java/org/jitsi/jigasi/transcription/TranslationManager.java
Show outdated Hide outdated src/main/java/org/jitsi/jigasi/transcription/TranslationManager.java
Show outdated Hide outdated src/main/java/org/jitsi/jigasi/transcription/TranslationManager.java
Show outdated Hide outdated src/main/java/org/jitsi/jigasi/transcription/TranslationManager.java
Show outdated Hide outdated src/main/java/org/jitsi/jigasi/transcription/TranslationManager.java

@nikvaessen nikvaessen merged commit aa5d866 into jitsi:master Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment