New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets source language for transcription with presence update #127

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
2 participants
@pvgupta24
Contributor

pvgupta24 commented Jul 25, 2018

  • Relies on jitsi/jitsi#509.
  • pom.xml to be updated with the new jitsi-desktop-version.
    Source language can be set by :
    APP.conference._room.setLocalParticipantProperty('transcription_language','hi-IN');
@pvgupta24

This comment has been minimized.

Show comment
Hide comment
@pvgupta24
Contributor

pvgupta24 commented Jul 25, 2018

@nikvaessen

This comment has been minimized.

Show comment
Hide comment
@nikvaessen

nikvaessen Jul 30, 2018

Contributor

I would also expect this PR would make changes to GoogleCloudTranscriptionService to actually use the given source language.

Contributor

nikvaessen commented Jul 30, 2018

I would also expect this PR would make changes to GoogleCloudTranscriptionService to actually use the given source language.

@pvgupta24

This comment has been minimized.

Show comment
Hide comment
@pvgupta24

pvgupta24 Jul 30, 2018

Contributor

@nikvaessen Participant sends the source language locale in the TranscriptionRequest which is being updated on presence update and used by GoogleCloudTranscriptionService.

Contributor

pvgupta24 commented Jul 30, 2018

@nikvaessen Participant sends the source language locale in the TranscriptionRequest which is being updated on presence update and used by GoogleCloudTranscriptionService.

@nikvaessen nikvaessen merged commit 6a0f263 into jitsi:master Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment