New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor of GatewaySession and SipGateway #54

Merged
merged 3 commits into from Jul 17, 2017

Conversation

Projects
None yet
3 participants
@nikvaessen
Contributor

nikvaessen commented Jul 17, 2017

This pr splits up Sipgateway into an AbstractGateway which is now extended by SipGateway.
The same happened to GatewaySession, creating an AbstractGatewaySession which only has code regarding joining a conference and SipgatewaySession, which is the old GatewaySession.

Due to these changes the SipGatewayListener and GatewaySessionListener have been modified to now
listen for the abstract versions.

Includes minor changes in other classes (mainly changes types to SipGatewaySession)

Also adds a notification for members leaving a conference (from JvbConference to AbstractGatewaySession)

@damencho damencho self-requested a review Jul 17, 2017

@bgrozev bgrozev merged commit d4c3f8f into jitsi:master Jul 17, 2017

@nikvaessen nikvaessen deleted the nikvaessen:refactoring branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment