New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how transcript are saved to more easily serve them with nginx/jetty #74

Merged
merged 6 commits into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@nikvaessen
Contributor

nikvaessen commented Aug 14, 2017

No description provided.

@bgrozev

This comment has been minimized.

Show comment
Hide comment
@bgrozev

bgrozev Aug 16, 2017

Member

The overall design looks good to me -- it's easy to add a new implementation and enable it via configuration properties. I've left a couple more comments inline.

Member

bgrozev commented Aug 16, 2017

The overall design looks good to me -- it's easy to add a new implementation and enable it via configuration properties. I've left a couple more comments inline.

@nikvaessen

This comment has been minimized.

Show comment
Hide comment
@nikvaessen

nikvaessen Aug 18, 2017

Contributor

added a push which plays together with the changes in lib-jitsi-meet
jitsi/lib-jitsi-meet#575 (comment)

Contributor

nikvaessen commented Aug 18, 2017

added a push which plays together with the changes in lib-jitsi-meet
jitsi/lib-jitsi-meet#575 (comment)

@bgrozev bgrozev merged commit 960c955 into jitsi:master Aug 18, 2017

@nikvaessen nikvaessen deleted the nikvaessen:refactor_transcripthandler branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment