New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug regarding messageID's and interim results #80

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
2 participants
@nikvaessen
Contributor

nikvaessen commented Aug 24, 2017

We closed a session when Google send an END_OF_SINGLE_UTTERANCE event, which
was received before the final result came in. This resulted in the
JSON object with the final result getting a new message ID.

This commit fixed this issue by making a new ResponseObserver
for each session, where each ResponseObserver has its own
unique ID

Fix a bug regarding messageID's and interim results
We closed a session when Google send an END_OF_SINGLE_UTTERANCE event, which
was received before the final result came in. This resulted in the
JSON object with the final result getting a new message ID.

This commit fixed this issue by making a new ResponseObserver
for each session, where each ResponseObserver has its own
unique ID

@bgrozev bgrozev merged commit 98a6733 into jitsi:master Sep 29, 2017

@nikvaessen nikvaessen deleted the nikvaessen:fix_message_id branch Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment