Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback on enter request for unauthorized users #10295

Closed
iospro opened this issue Nov 2, 2021 · 9 comments
Closed

Callback on enter request for unauthorized users #10295

iospro opened this issue Nov 2, 2021 · 9 comments
Labels
feature-request Issue which suggest an idea, enhancement or feature to implement wontfix Issue won't be fixed

Comments

@iospro
Copy link
Contributor

iospro commented Nov 2, 2021

It would be useful to add callback on enter request for unauthorized users.
For example, in iOS JitsiMeetViewDelegate we have callback

- (void)participantJoined:(NSDictionary *)data

When unauthorized user comes we have on-screen message with two buttons Allow/Disallow.
It would be nice to have some callback as

- (void)participantIsWaiting:(NSDictionary *)data

data contains basic information on a new user (some userGuid)

Also we need some method to Allow/Disallow to enter in parallel with current in-box mechanism

  • (void)enterParticipant:(NSString *)userGuid allow:(BOOL)allow

This SDK extension allows to notify admin about new waiting participants while screencasting outside the custom Jitsi App.
In such case the App can make a local notification with interactive buttons on participantIsWaiting event to allow/disallow enter for new participant without need to enter the Jitsi App

This feature is needed in all platforms.

@iospro iospro added the feature-request Issue which suggest an idea, enhancement or feature to implement label Nov 2, 2021
@saghul
Copy link
Member

saghul commented Nov 2, 2021

You mean lobby actions, right?

@iospro
Copy link
Contributor Author

iospro commented Nov 2, 2021

Yes, incoming lobby event and programmical reaction on this event via SDK API

@saghul
Copy link
Member

saghul commented Nov 2, 2021

Got it. I don't think we have short term plans to add this, but any PR is welcome.

@iospro
Copy link
Contributor Author

iospro commented Nov 4, 2021

Could you please describe how we can get to know which commits from master branch were included into some SDK release? We can't find release notes and commit relations in SDK repo

@saghul
Copy link
Member

saghul commented Nov 4, 2021

It's right here: https://github.com/jitsi/jitsi-meet-release-notes/blob/master/CHANGELOG-MOBILE-SDKS.md

That includes the release notes and links to the tag and list of commits on a given release.

It's also linked in the "releases" tab on the handbook: https://jitsi.github.io/handbook/docs/releases

@iospro
Copy link
Contributor Author

iospro commented Nov 23, 2021

Could you please make a suggestion about the date of the next release iOS/android sdk? We made some pull requests with very important for us localization improvements.

@saghul
Copy link
Member

saghul commented Nov 23, 2021

We are hoping for a release late this week or the next.

@iospro
Copy link
Contributor Author

iospro commented Nov 30, 2021

very hope this week

@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Apr 18, 2022
@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Issue which suggest an idea, enhancement or feature to implement wontfix Issue won't be fixed
Projects
None yet
Development

No branches or pull requests

2 participants