Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offer to include a custom CSS file #9422

Closed
rasos opened this issue Jun 21, 2021 · 2 comments
Closed

offer to include a custom CSS file #9422

rasos opened this issue Jun 21, 2021 · 2 comments
Labels
feature-request Issue which suggest an idea, enhancement or feature to implement

Comments

@rasos
Copy link
Contributor

rasos commented Jun 21, 2021

If you browse through the community forum we can see several questions regarding slight adaptions of the style. This usually requires de-minifying the all.css file and apply changes there. However all the changes get lost after each update.

The DevOps life would be easier, if a custom.css file would be included, which does not get updated automatically.

Two observations with all.css when customizing it:

We had to remove the 100% lines two times, otherwise links can not be clicked on the WelcomePageAdditionalContent.html page on the bottom:

.welcome .welcome-watermark {
    position: absolute;
    width: 100%;
    height: 100%}

In order to make use of another font defined later in all.css we had to remove important! at the end of

body, button, input, keygen, select, textarea {
    font-family: -apple-system, BlinkMacSystemFont, open_sanslight, "Helvetica Neue", Helvetica, Arial, sans-serif;
}
@rasos rasos added the feature-request Issue which suggest an idea, enhancement or feature to implement label Jun 21, 2021
@damencho
Copy link
Member

You can always include your css before or after the all.css file.
Before it you can include it in https://github.com/jitsi/jitsi-meet/blob/master/head.html
Or after it in https://github.com/jitsi/jitsi-meet/blob/master/plugin.head.html
You can define your set of files and source them from etc folder in the nginx config similar the config.js file ...

For the other problems, you have with !important and position you can create a PR with the changes and we can review and merge it to be available in future versions.
Or include some kind of sample for testing with the PR or here in the issue so we can make sure if we need changes to make it compatible with your example and our branding for meet.jit.si ... Thank you.

@damencho
Copy link
Member

For the links problem that is strange, but you can check the welcomepage of https://meet.jit.si, there are already links about privacy policy and terms, and the app store/google store links, you can check how that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Issue which suggest an idea, enhancement or feature to implement
Projects
None yet
Development

No branches or pull requests

2 participants