Skip to content

feat(tile-view): allow disabling thumbnail enlargement - #10494

Merged
saghul merged 1 commit into
jitsi:masterfrom
jbg:master
Dec 2, 2021
Merged

saghul merged 1 commit into
jitsi:masterfrom
jbg:master

Conversation

@jbg

@jbg jbg commented Dec 1, 2021

Copy link
Copy Markdown

Allows disabling the enlargement (objectFit: cover) of thumbnails using a config option called disableTileEnlargement.

Closes #10358

@jitsi-jenkins

Copy link
Copy Markdown

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul saghul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, LGTM otherwise.

Comment thread react/features/filmstrip/components/web/Thumbnail.js Outdated
@saghul

saghul commented Dec 1, 2021

Copy link
Copy Markdown
Member

Jenkins please test this please.

saghul
saghul previously approved these changes Dec 1, 2021
@saghul

saghul commented Dec 1, 2021

Copy link
Copy Markdown
Member

Looks like there are some linting issues.

@saghul

saghul commented Dec 1, 2021

Copy link
Copy Markdown
Member

Jenkins please test this please.

@saghul
saghul merged commit ed6f6cf into jitsi:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tile View "Landscape Mode" for Two-Party Calls

3 participants