Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow jitsi meet to be opened in a mobile browser #3518

Closed
wants to merge 1 commit into from

Conversation

riyadhzen
Copy link

@riyadhzen riyadhzen commented Oct 8, 2018

Allow jitsi meet to run on a mobile browser based on a config parameter in the "interface_config.js".

This topic came up a couple of times in the mailing list and the current solution as suggested here is not ideal.

This feature is really useful for audio only requirements in apps that integrate with jitsi meet through the external api.

Note: Running jitsi meet in the browser of a device is useless where webrtc is not supported.

@jitsi-jenkins
Copy link

@jitsi-jenkins jitsi-jenkins commented Oct 8, 2018

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@riyadhzen
Copy link
Author

@riyadhzen riyadhzen commented Oct 8, 2018

Already signed

@saghul
Copy link
Member

@saghul saghul commented Oct 8, 2018

We have done this on purpose. The experience is not designed for use in a mobile browser. That said, since it's an option which defaults to false (the current behavior), I find it acceptable. @jitsi/atlassian-devs thoughts?

@stale
Copy link

@stale stale bot commented Jan 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 6, 2019
@stale stale bot closed this Jan 13, 2019
@ghost
Copy link

@ghost ghost commented Jan 13, 2019

Disappointing.

@Demi-ob
Copy link

@Demi-ob Demi-ob commented Mar 26, 2019

Has it been merged

@saghul saghul reopened this Mar 27, 2019
@stale stale bot removed the wontfix label Mar 27, 2019
@@ -69,6 +69,11 @@ export function getDeepLinkingPage(state) {
const isUsingMobileBrowser = OS === 'android' || OS === 'ios';

if (isUsingMobileBrowser) { // mobile
const openInBrowser = interfaceConfig.OPEN_IN_MOBILE_BROWSER || false;
Copy link

@pussbb pussbb May 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would not be better do in following way

if (typeof interfaceConfig === 'object') {
        const {
            OPEN_IN_MOBILE_BROWSER: openInMobileBrowser = false,
            MOBILE_APP_PROMO: mobileAppPromo = true
        } = interfaceConfig;

        if (!openInMobileBrowser) {
            const OS = Platform.OS;
            const isUsingMobileBrowser = OS === 'android' || OS === 'ios';

            if (isUsingMobileBrowser) { // mobile
                return Promise.resolve(
                    mobileAppPromo ? DeepLinkingMobilePage : NoMobileApp);
            }
        }
    }

@SovietMan
Copy link

@SovietMan SovietMan commented Aug 2, 2019

I get why mobile access without app has been restricted, but I think we should allow the option on allowing mobile connections but limit them to voice only since that's probably WAY easier to keep the code working if we only have to worry about the voice side of things.

And the only change we would have to do for the mobile landing page is notifying them of the limitation to voice only and offer them a "connect anyway" button and the "download app" button.

@stale
Copy link

@stale stale bot commented Dec 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 27, 2019
@Demi-ob
Copy link

@Demi-ob Demi-ob commented Jan 1, 2020

Has it been merged to production?

@stale stale bot removed the wontfix label Jan 1, 2020
Demi-ob
Demi-ob approved these changes Jan 1, 2020
@VaiTon
Copy link

@VaiTon VaiTon commented Mar 16, 2020

bump

@lajon9
Copy link

@lajon9 lajon9 commented Mar 21, 2020

Bump

@rickgoud
Copy link

@rickgoud rickgoud commented Mar 22, 2020

Would indeed be very great if this could me merged to master and wrapped into stable. Would be great if users do not need to install an app first!

@rsjr
Copy link

@rsjr rsjr commented Mar 25, 2020

Can this feature be merged? We are working on several projects related to Covid19 (related to telemedicine for people in quarentine) and this is very important as the majority of the users won't have Jitsi app installed

@chamerling
Copy link

@chamerling chamerling commented Mar 26, 2020

Hello @saghul, all,

Being able to open jitsi on (at least) a tablet should be OK on the UI side. If I am not wrong, most of the OS now supports everything required to have jitsi running correctly on such devices.
This PR from @riyadhzen does not break everything else and just adds a variable in the configuration and so it will be really nice, since the dev community is asking for it, to have this PR reviewed and merged. If you think that more is needed to have this feature, please ask.

Thanks a lot

@saghul
Copy link
Member

@saghul saghul commented Mar 26, 2020

I'll bring it up with the team once more.

@rsjr
Copy link

@rsjr rsjr commented Mar 27, 2020

Hi @chamerling @saghul . I am sorry to bother you with this again, but can you please prioritize this merge? Thanks!

@saghul
Copy link
Member

@saghul saghul commented Mar 27, 2020

We cannot land it as is. We now have plans to allow this, but we need to make some extra changes first.

@frobinsonj
Copy link

@frobinsonj frobinsonj commented Mar 28, 2020

We cannot land it as is. We now have plans to allow this, but we need to make some extra changes first.

If there is any way I can contribute to speed this up, I would be more than happy to. I am sure there are others who would be eager as well.

@chamerling
Copy link

@chamerling chamerling commented Mar 28, 2020

@saghul can you give more details about the "extra changes"?

@wmikun
Copy link

@wmikun wmikun commented Mar 28, 2020

@saghul may you please provide more information regarding expected timeline? This is an urgently needed feature. Thank you!

@daxiondi
Copy link

@daxiondi daxiondi commented Aug 14, 2020

Hope the community can reconsider and make jitsi work in mobile browsers

@saghul
Copy link
Member

@saghul saghul commented Aug 14, 2020

This has already been implemented and it's rolled out in production in meet.jit.si. You'll now see a button which says "Launch in web".

Screenshot 2020-08-14 at 10 23 44

@Vacika
Copy link

@Vacika Vacika commented Aug 14, 2020

It seems that the issue about toggling the video camera on/off when accessing via mobile browser still persists.
Could you check this up?
Thanks.

@saghul
Copy link
Member

@saghul saghul commented Aug 14, 2020

That should be fixed too. If it isn't, please do open a new issue.

@daxiondi
Copy link

@daxiondi daxiondi commented Aug 17, 2020

I tested in meet.jitsi.si Can see the start network button.
I use the site of quick installation, but unfortunately did not see
what do I need to do to make my site can and meet.jitsi.si It works as well

@daxiondi
Copy link

@daxiondi daxiondi commented Aug 19, 2020

这已经实施,并已在met.jit.si中正式投入生产。现在,您将看到一个按钮,上面显示“启动网络”。

2020-08-14屏幕快照10 23 44

What version of jitsi meet can see the above changes, looking forward to your reply.

@daxiondi
Copy link

@daxiondi daxiondi commented Aug 20, 2020

@saghul Waiting for your reply.

@Aokromes
Copy link

@Aokromes Aokromes commented Sep 2, 2020

I tried to test it on LosQ (lineageos fork) browser and i get error obtaining camera (and microphone) permision a lot of blablabla you can use camera button on browser bar (but i don't see any)
Tried with bromite and works fine.

@alejandroparra
Copy link

@alejandroparra alejandroparra commented Sep 4, 2020

Pretty sure most of you are making changes in wrong place. You might be doing in /usr/share/jitsi-meet-web-config/config.js or /usr/share/jitsi-meet/interface_config.js

Both are wrong

You need to modify /etc/jitsi/meet/yourwebsite.com-config.js file.

And you need to uncomment that line and set the value to true for the setting to work.
Change from
// disableDeepLinking: false,

To

disableDeepLinking: true,

You dont need to even restart the services. It works immediately.

This is the Final solution, it works like charm

@egzon-mmustafa
Copy link

@egzon-mmustafa egzon-mmustafa commented Sep 6, 2020

Can this feature be merged? We are working on several projects related to Covid19 (related to telemedicine for people in quarentine) and this is very important as the majority of the users won't have Jitsi app installed

configOverwrite: { disableDeepLinking: true }

@amirkhattak
Copy link

@amirkhattak amirkhattak commented Sep 25, 2020

i am facing on mobile same issue its says download app how can i fix this issue i am using iframe base external api

@saghul
Copy link
Member

@saghul saghul commented Sep 25, 2020

This is now available on the latest stable release (and has been for a while).

@amirkhattak
Copy link

@amirkhattak amirkhattak commented Sep 25, 2020

i am using api external api based <script src="https://meet.jit.si/external_api.js"></script> its work on desktop pc laptop but on mobile its show app download

@saghul
Copy link
Member

@saghul saghul commented Sep 25, 2020

Hum, do you have a test HTML page available to test?

@amirkhattak
Copy link

@amirkhattak amirkhattak commented Sep 25, 2020

i did within my chat room with a box model

@amirkhattak
Copy link

@amirkhattak amirkhattak commented Sep 25, 2020

https://chat.pakistanichatzone.com/ its my chat link

@saghul
Copy link
Member

@saghul saghul commented Sep 25, 2020

I mean a reduced example that can be run locally.

@amirkhattak
Copy link

@amirkhattak amirkhattak commented Sep 25, 2020

can u join me on anydesk so i can show u how i did

@amirkhattak
Copy link

@amirkhattak amirkhattak commented Sep 25, 2020

WhatsApp Image 2020-09-25 at 2 42 27 AM
this the screen shot of issue i am facing

@saghul
Copy link
Member

@saghul saghul commented Sep 25, 2020

Wait, the button is there: "Launch in web"

@amirkhattak
Copy link

@amirkhattak amirkhattak commented Sep 25, 2020

i tried launch in web but its not working would u please join me on anydesk so i can show u

@amirkhattak
Copy link

@amirkhattak amirkhattak commented Sep 25, 2020

thanku i fixed my issue

@dinesh192
Copy link

@dinesh192 dinesh192 commented Oct 15, 2020

Still, I am not getting a fix for it. Video is not opening in the Mobile browser. I tried using the startWithVideoMuted: false but not working

@mcote7
Copy link

@mcote7 mcote7 commented Dec 13, 2020

Hi, i'm trying

disableDeepLinking: true

in the config.js file

Is there anything else i should do? tried restart services, system but changes doesn't apply for some reason.

Edit. I only got it working forcing chrome to load the desktop website.
Edit2. It works when i force the option like this:

https://URL of yourserver.com/room#config.disableDeepLinking=true

Thanks

i think also need = {prejoinPageEnabled: false}

@vijaylincod
Copy link

@vijaylincod vijaylincod commented Jan 12, 2021

is there any way to open directly in mobile web browser without any popup.

@saghul
Copy link
Member

@saghul saghul commented Jan 12, 2021

No, sorry.

@mcote7
Copy link

@mcote7 mcote7 commented Jan 12, 2021

@SandeepGamot
Copy link

@SandeepGamot SandeepGamot commented Mar 15, 2021

Pretty sure most of you are making changes in wrong place. You might be doing in /usr/share/jitsi-meet-web-config/config.js or /usr/share/jitsi-meet/interface_config.js
Both are wrong
You need to modify /etc/jitsi/meet/yourwebsite.com-config.js file.
And you need to uncomment that line and set the value to true for the setting to work.
Change from
// disableDeepLinking: false,
To
disableDeepLinking: true,
You dont need to even restart the services. It works immediately.

This is the Final solution, it works like charm

Hey Thanks alot, that solves the issue for me, but I'm wondering what is deepLinking and what are we losing on by disabling that, any bugs? I'm using this is in an online classroom feature, where hundreds of students will join, will this affect any functionalities by any chance, thanks alot.

@ahmadzt
Copy link

@ahmadzt ahmadzt commented Jun 28, 2022

if anyone looking for answer on 2022, it should be something like this

<Jitsi
  config={{
    disableDeepLinking: true,
    prejoinConfig: false,
  }}
/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet