New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm deps work #366

Merged
merged 2 commits into from Oct 6, 2015

Conversation

Projects
None yet
3 participants
@dwilson6
Contributor

dwilson6 commented Oct 5, 2015

This work pulls the remaining dependencies of jitsi-meet from npm (jquery, strophe, jquery-ui, various plugins). Right now they are all bundled into the app.bundle.min.js which doubles the size of the bundle and the time to run browserify. It could all stay in one bundle or I could move all the dependencies to a separate vendor bundle.

Before:
~5.7s and 646K bundle
After:
~10.5s and 1.2M bundle

@bgrozev

This comment has been minimized.

Show comment
Hide comment
@bgrozev

bgrozev Oct 5, 2015

Member

This is awesome! I just ran jitsi-meet-torture against it and everything passed. I think we should keep everything in one file as it is.

Does anyone see a reason not to merge this?

Member

bgrozev commented Oct 5, 2015

This is awesome! I just ran jitsi-meet-torture against it and everything passed. I think we should keep everything in one file as it is.

Does anyone see a reason not to merge this?

@gpolitis

This comment has been minimized.

Show comment
Hide comment
@gpolitis

gpolitis Oct 5, 2015

Member

This is awesome, indeed! I haven't tested it, but the code looks perfectly fine. Thanks @dwilson6 !

Member

gpolitis commented Oct 5, 2015

This is awesome, indeed! I haven't tested it, but the code looks perfectly fine. Thanks @dwilson6 !

gpolitis added a commit that referenced this pull request Oct 6, 2015

Merge pull request #366 from pstros/npm-deps-work
Use npm to manage external dependencies. Closes #346.

@gpolitis gpolitis merged commit dbd8d30 into jitsi:master Oct 6, 2015

@dwilson6 dwilson6 deleted the pstros:npm-deps-work branch Dec 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment