Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(external_api): Fix screensharing for firefox 74 #5180

Merged
merged 1 commit into from Mar 18, 2020

Conversation

Arzar
Copy link
Contributor

@Arzar Arzar commented Mar 16, 2020

Starting from version 74, firefox need to be explicitly allowed to capture the screen from an iframe for screensharing. This new Feature-Policy is called "display-capture".
See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy/display-capture

Starting from version 74, firefox need to be explicitly allowed to capture the screen from an iframe for screensharing. This new Feature-Policy is called "display-capture".
See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy/display-capture
@jitsi-jenkins
Copy link

@jitsi-jenkins jitsi-jenkins commented Mar 16, 2020

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

saghul
saghul approved these changes Mar 17, 2020
@saghul
Copy link
Member

@saghul saghul commented Mar 17, 2020

@jallamsetty1 can you please check if this doesn't break Chrome or older Firefox releases?

@jallamsetty1
Copy link
Member

@jallamsetty1 jallamsetty1 commented Mar 17, 2020

@jallamsetty1 can you please check if this doesn't break Chrome or older Firefox releases?

Sure, will do.

@jallamsetty1
Copy link
Member

@jallamsetty1 jallamsetty1 commented Mar 17, 2020

Works on Firefox 73, no errors/warnings seen there.
Chrome throws a warning that it's an unrecognized feature. However, screensharing works fine w/o any issues.

Screen Shot 2020-03-17 at 5 40 48 PM

VaiTon
VaiTon approved these changes Mar 18, 2020
@saghul
Copy link
Member

@saghul saghul commented Mar 18, 2020

I’d say let’s land it then, since it’s in the W3C doc: https://www.w3.org/TR/screen-capture/

@joekerna
Copy link

@joekerna joekerna commented Mar 29, 2020

For me even with this PR there is still no screen sharing button in Firefox 74.
It's working fine in Firefox 73 so I guess the configuration is correct?!

@luixxiul luixxiul added the api label May 21, 2020
@luixxiul luixxiul added the info:cla-signed label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api info:cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants