Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Removes an unnecessary lock acquisition in order to prevent a deadlock #119
Well... I agree that the original code before the modification wasn't good at protecting the TransportManager.channels List and, consequently, removing the synchronized block shouldn't make a (theoretically) bad situation worse. I'd rather we at least fix the (theoretically) possible ConcurrentModificationException (which I've fixed locally and I'm currently testing) in addition to fixing the deadlock. Anyway, @bgrozev, please feel free to merge your pull request.