Command line call param do not recognise account if domain is IP address #471
Comments
r3code
added a commit
to r3code/jitsi
that referenced
this issue
Apr 26, 2018
r3code
added a commit
to r3code/jitsi
that referenced
this issue
Apr 26, 2018
zymptomLabs
added a commit
to serverplus/jitsi
that referenced
this issue
May 10, 2021
* Fix manifest * Revert change of parent from master-merge * Fix creation of RayoIqs found by tests in Jigasi TODO: move the test in Jigasi to Jitsi * Fix namespace of media/source extension * Fix empty extension elements * Fix some jingle extension namespaces * Add a utility method for the Hammer * Fix an invalid type comparison * Update the jnsapi version. * Update Smack to 4.2.1 final * Fixes JibriIQ creation. * Update Maven versions to 2.13-SNAPSHOT * Update jingle nodes to released version * Adds modifications to colibri protocol. Deprecates <channel-bundle in favor of <endpoint in conference xmpp iq. Deprecates use of channel-bundle-id attribute of channel node. * Introduces stats-id xmpp extension. Stats-id is used in jitsi-meet. * Fixes some comments. * Partially reverts 4e2ac86, keeps channel-bundle, just adds endpoint. Adds endpoint with its attributes, stats-id, display name. Moves jitsi-meet xmpp extensions to the correct package. * ref: Moves the "type" attribute to ChannelCommon. * ref: Cleans up ColibriBuilder. * ref: Always uses IQ type set for Colibri. * ref: Refactors addBundleTransportUpdateReq to take the ID as a parameter, instead of having to extract it from a ColibriConferenceIQ. * ref: Refactors addRtpDescription to take the description and channel ID as parameters instead of having to extract them. * minor: Renames a variable for consistency. * ref: Uses (more) consistent naming. * It never worked. * Disable profile in advanced video config. Removes dependency. * add fec-fr group semantics * Adds openh264 license text to windows installer and in about window. * Update to Java 8 * Prevent ConcurrentModificationException when entering sleep * Fix jitsi.exe manifest for MSBuild * Add CMake project to easily build with VS Requires the presence of config.h, created with the legacy Makefile * Fix a bunch of wrong unicode/tchar usages * Add %ProgramData%\Jitsi\native to java.libary.path * Moves download from updates to desktopUtils to be reused. * Adds OpenH264 configuration, downloading, disabling. * Skips a dialog when downloading from settings panel. * Adds a link to the license of OpenH264 in the config panel. * Add commons-compress 1.15 binary * Fix FileUtil ambiguities * Fix Eclipse classpath * Prefix Windows OpenH264 with lib as expected by FFmpeg * Colibri fixes and cleanup (jitsi#423) * minor: Makes methods static (as suggested by @bbaldino). * fix: Fixes a problem with ColibriBuilder accumunating ChannelBundle instances in its conferenceState. Refactors ColibriConferenceIQ to contain ChannelBundles mapped by their ID. * fix: Fixes a problem with ColibriBuilder accumunating Endpoint instances in its conferenceState. Refactors ColibriConferenceIQ to contain Endpoints mapped by their ID. * feat: Supports setting sources and source groups at channel allocation time. * minor: Renames a variable. * fix: Fixes a log message. * ref: Makes a copy of the PayloadPacketExtension-s and RTPHdrExtPacketExtension-s. * fix jitsi could not transfer file with thumbnail The reason is that in the method FileElement::parseIQ where is the line "thumbnail = new ThumbnailElement(parser.getText())" where parser.getText() equals something like <thumbnail xmlns="..." cid="..." mime-type="image/png" width="64" height="64"> (note closing '>' instead of '/>'). That's why exception occurs in the constructor of ThumbnailElement org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 160; XML document structures must start and end within the same entity. * fix: Fixes copying of PayloadPacketExtension (jitsi#446) * fix: Fixes copying of PayloadPacketExtension Uses a static clone() method instead of a copy constructor, because AbstractPacketExtension already has one, which can be easily reused to copy all attributes. * test: Adds tests for PayloadTypePacketExtension. * ref: Addresses feedback. * test: Configures maven to run some tests. Only the tests in protocol-jabber are enabled, because I couldn't make any of the other ones work with maven. * Hide send message menu item if no supported provider available * Collapse call menu if there is only one item in the menu * Show failure if a history contact cannot be used to send a message * Prevent adding contact detail if there is no matching call provider * Remove dead code * Fixes openh264 panel, to be shown only in general video config. * Updates libjitsi and jitsi-lgpl-dependencies. * Updated deb dependencies. * Adds addOctoRelays to ColibriBuilder. (jitsi#452) * fix: Adds null checks. * ref: Refactors getRequestChannel, adds support for OctoChannel. * feat: Adds addOctoRelays to ColibriBuilder. * Fix parsing ssrc info (jitsi#454) * ref: Uses generic type inference. * fix: Uses a DefaultPacketExtensionProvider to parse SourcePacketExtensions (since the ad-hoc parsing code which we used to have failed to parse their "paramater" and "ssrc-info" children). * test: Adds a test for parsing the children of "source". * Updates debian dependencies. * Updates jitsi-lgpl-dependencies and libjitsi. * fix: Fixes the jingle nodes harvester (fixes jitsi#424). Based on @elisafk's report. * Fix NPE on call state change Closes jitsi#441 * Improve handling of OAuth2 code acquisition Closes jitsi#444 * Fixes win x86 build. * Updates jitsi-lgpl-dependencies and libjitsi. As libjitsi moved to java 1.8, there is temporary branch jitsi-desktop in libjitsi till jitsi moves to java 1.8. The libjitsi is from that branch. * add the youtube broadcast id to the JibriIq * Fix issue jitsi#471 Made protocol uri check more general, allow domain part to be an IP-address. * Prevents possible NPE in PacketLogging service. * Changes to Jibri recording flows (jitsi#475) * add session-id attribute to jibri-recording-status * add session id to JibriIq * remove 'available' status we'll no longer publish availability to clients * tweaks to recording messaging flows * update the sipcallstate message * add the session id to sip call state message, add some missing comments * add receording mode to RecordingStatus * more cleanup * Pass username on xmpp conn.login. We need to pass username, not the bare jid when we call connection.login . * Fix usage of CertificateVerificationService * Implements createSslContext in xmppp AnonymousLogin. * Disables unused experimental service. When doing disco-info on login HttpFileUploadManager prints a lot of errors. * Uses new BOSHConfiguration format to pass bosh url to use. Activates stats-id provider. * use MediaPresenceExtension.Source to extract ssrc from source-add jingle * Shows a warning that master password is not enabled. Fixes jitsi#461. * Updates debian deps. * Updates debian deps. Adds and libavfilter-extra6. * feat: Adds conveneince methods. * feat: Implements cloning for ColibriStatsExtension. * feat: Adds more convenience methods. * fix: Fixes compliation and tests new methods. * add ability to intercept Presence objects received by ChatRoomJabberImpl and add presence extensions (jitsi#483) * add ability to intercept Presence objects received by ChatRoomJabberImpl * rename method and put interface in separate file * Revert "rename method and put interface in separate file" This reverts commit 3a78432. * Revert "add ability to intercept Presence objects received by ChatRoomJabberImpl" This reverts commit 1b52068. * add ChatRoomMemberPresenceEvent.MEMBER_UPDATE and store last presence * Add presence extensions for elements 'avatar-id' and 'identity' * Add the Identity and AvatarId Extensions to ProviderManager * fix errors in parsing StrideIdentity * rename StrideIdentityPresenceExtension to IdentityPresenceExtension * ref: Renames classes. * Reuse AbstractPacketExtension and DefaultPacketExtensionProvider. * add log warning for failing to parse IdentityPacketExtension * Creates issue templates * Remove namespace from ContentPacketExtension * fix constructor in AvatarIdExtension and delete usage of DataObject API * Remove namespace from ContentPacketExtension * Adds json message extension (jitsi#495) * Adds json message extension (cherry picked from commit 149921d) * Uses AbstractPacketExtension for json-message * Send JsonMessage without body and minor fixes * Adds utility method for sending message and formatting fixes * Translation language presence extension added (jitsi#504) (cherry picked from commit 51a87a8) * Escape any extension content to be xml friendly. (jitsi#508) * Add presence extension for setting source language for transcription * fix: Allows sendPresenceExtension to have more than one element with the same namespace. * feat: Moves the removeExtension method to AbstractPacketExtension. * FIX: Don't start the Smack Debugger UI by default. This seems to be a leftover from earlier development. It causes the Smack debugger UI to instantiate, which is often quite undesirable. As this code is reused on server components, (eg jigasi), it can cause startup problems on headless environments too. * Add app_data field to JibriIq (jitsi#517) This field contains a JSON-encoded string which can be used to pass application data to Jibri without the need to add a new field in the IQ every time. * Add TranscriptStatusExtension (jitsi#520) * add TranscriptionStatusExtension * fix the getStatus method * add TranscriptRequestExtension (jitsi#522) * Clears some listeners on unregistering xmpp account. The listeners end up in static collections in smack and will never be removed which will result leaking protocol provider instances. * Uses callStateChanged to track ended calls. If there is a running call, or call which is in a process of hanging up and we unregister the provider, it can happen that we remove callListener before detecting that call is ended and those ended calls will stay forever in the calls list. * fix: Adds a null check. * Avoids duplicating vcard extension in outgoing presence. * Fixes IllegalArgumentException: The Resourcepart must not be null. The error is on join, as we check for member nickname before smack is able to save it. java.lang.IllegalArgumentException: The Resourcepart must not be null at org.jxmpp.jid.impl.AbstractJid.requireNonNull(AbstractJid.java:243) at org.jxmpp.jid.impl.LocalDomainAndResourcepartJid.<init>(LocalDomainAndResourcepartJid.java:49) at org.jxmpp.jid.impl.JidCreate.entityFullFrom(JidCreate.java:838) at net.java.sip.communicator.impl.protocol.jabber.ChatRoomJabberImpl$ChatRoomPresenceListener.processStanza(ChatRoomJabberImpl.java:3087) * Update DNSSEC root trust anchor Ref: https://data.iana.org/root-anchors/ * Prevent reinit of webcam when putting a call on hold - Video mute is supported meanwhile - Setting direction.inactive caused the webcam to be stopped, but it was the immediately restarted by the reInvite OK's recvonly media direction. The DirectShow implementation cannot handle such a fast reinit. Closes jitsi#396 * Prevent two successive calls to open the webcam The DirectShow backend was almost guaranteed to fail on one * Fixes jitsi#521 by adding sharing region before staring remote control and destroys origin when sharing is disabled * Fixes jitsi#104. Now it's possible to type on remote machine and works simple navigation such as backspace, enter and arrow keys. * Mac command / Win key translations * Remove workarounds for long fixed JRE bugs * Add type information to DefaultContactList * Move the chat contact list to chat.conference package * Re-enable drag&drop for the chat contact list Fixes jitsi#75 Closes jitsi#533 * Clear the default text during drag&drop operations * Fixed issue when remote control doesn't work when user enabled it during connection state * Fixed 404 URLs inside CONTRIBUTING.md * overhaul the jibri status presence extension (jitsi#539) * overhaul the jibri status presence extension jibri's status is now composed of 2 'sub statuses': its busy status (whether or not this jibri is currently handling a request) and its health status (whether or not this jibri has encountered and error and needs intervention before it can handles requests again). * move function for getting a child extension to AbstractPacketExtension * Updates ping interval in xmpp accounts. * Does not initialize jnodes if it is disabled. * Fixes build compilation. * Updates port tracker to always validate port, is it in range. * Fixes maven build. Missing some dependencies after merging https://github .com/jitsi/pull/545. * Fixes possible NPE. * Disables SingleCallInProgressPolicy with the property. * Adds properties to disable certain features. Enabled by default. * Fixes connections throwing SmackException.NoResponseException. When there is a timeout connecting and the connection throws SmackException.NoResponseException, this is caught and we return to retry connection, but there is no reflection in the state of the provider and the provider stays in registering state. * Fixes some NPE exceptions when tearing down calls. * Parse custom packet extensions in Jingle IQ * Fixes exception "The Resourcepart must not be null" on xmpp muc join. Sometimes while joining we receive the presence and dispatch the user role before nickname is stored in multiUserChat. Returning guest is just for the event reporting the new role and that old is guest. java.lang.IllegalArgumentException: The Resourcepart must not be null at org.jxmpp.jid.impl.AbstractJid.requireNonNull(AbstractJid.java:243) at org.jxmpp.jid.impl.LocalDomainAndResourcepartJid.<init>(LocalDomainAndResourcepartJid.java:49) at org.jxmpp.jid.impl.JidCreate.entityFullFrom(JidCreate.java:838) at net.java.sip.communicator.impl.protocol.jabber.ChatRoomJabberImpl.getUserRole(ChatRoomJabberImpl.java:1105) at net.java.sip.communicator.impl.protocol.jabber.ChatRoomJabberImpl.setLocalUserRole(ChatRoomJabberImpl.java:1135) at net.java.sip.communicator.impl.protocol.jabber.ChatRoomJabberImpl$ChatRoomPresenceListener.processOwnPresence(ChatRoomJabberImpl.java:3148) at net.java.sip.communicator.impl.protocol.jabber.ChatRoomJabberImpl$ChatRoomPresenceListener.processStanza(ChatRoomJabberImpl.java:3087) at org.jivesoftware.smack.AbstractXMPPConnection$5.run(AbstractXMPPConnection.java:1233) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) * feat: Supports rtcpmux with jingle/ice. * Cleans connection references on stopping provider. Leaving connections is dangerous as smack many static weak maps of connections and leaving a connection here makes a strong connection between the key and the value and this prevents a lot of objects to be garbage collected. * Configure the DTLS control with rtcpmux if it's in use. * Cleanups unnecessary checks. The member capsManager is final and there is no point of the null checks . * Cleanups ScServiceDiscoveryManager instances on stop. * Removes jitsi-universe dependency. * Updates pom with latest smack and libjitsi. * Updates libjitsi, uses jitsi-utils. * mvn: Sets the version of the surefure plugin. * Indicate failure to provider listeners when there is an exception. When there is SmackException trying to connect we ignore it and continue using the other address options, but it maybe the last one to try and no event is fired to provider listeners, which can lead of leaking providers in reconnection bundle for example. * Fixes encoding bosh url. If room name(url param) has a space in the name it will come encoded correctly, but calling .getQuery() decodes the query. * Moves move classes to jitsi-utils. * Updates libjitsi. * Moves jitsi xmpp extensions in separate library. (jitsi#582) * Fixes node information in service disco manager. Partially reverts 5307014, it was generating nodeAttribute too early when the version of the caps<anager is still not updated. * Fixes manifests after latest bundle changes. * Updates jitsi-xmpp-extensions, fixes start muted extension. * Update ScServiceDiscoveryManager to use smacks implementation. Removes our EntityCapsManager implementation and uses smack's one. The only duplication that was left(moved from EntityCapsManager into ScServiceDiscoveryManager) is storing userCaps <Jid, nodeVer> as we need it in order to be able to fire events to UserCapsNodeListener and to Capabilities OpSet. * Updates to latest smack-4.2 and jitsi bundles to be able to run app. * Fixes missing libs. * Fixes tests. * Fixes sip and jabber tests. * Adds a list of extensions added to the outgoing presences to the room. (jitsi#598) * Adds a list of extensions added to the outgoing presences to the room. * Fixes comments. * Adds a global property to disable sip reinvites on focus changed. * Adapts to the move of Version. (jitsi#604) * Adapts to the move of Version. * Updates libjitsi * Fixes missing import in bundle. * Replaced org.jitsi.util.StringUtils to org.apache.commons.lang3.StringUtils * Makes sending hole punch packets public. * fix: Copies the hole punch packet buffer before making changes to it. (jitsi#608) * Updates latest xmpp-extensions. Fixes jitsi#435. * Fixes loading xmpp bundle. * Fixes Jitsi version in about window. * Fixes some missing OSGi imports. * Removed deprecated API usage and fixed typos * Added import org.apache.commons.lang3 to manifests * Fixed review comments * Replaced org.jitsi.util.StringUtils to org.apache.commons.lang3.StringUtils * Removed deprecated API usage and fixed typos * Added import org.apache.commons.lang3 to manifests * Fixed review comments * Fixed commits related with toEncodedString usage * Fixed comments and removed duplicate import * Added missed import. Without import adding new XMPP account doens't work by java.langClassNotFound exception * Removed unused import and implemented new check number logic * Uses accountUID to compare AccountID instances. There are situations where we can have accounts with same userID, but just different servers to connect to (jigasi). * Cleanup connection after firing events so listeners can be removed. Smack uses the connection for obtaining features managers where we can cleanup listeners, if we cleanup xmpp connection before firing events we cannot cleanup the listeners. * Improves logging of providers and accounts loading. * Fixes leaking protocol providers in currentlyReconnecting. Protects currentlyReconnecting where it was not. Also ignore some reconnects on user request events. * Synchronizes translator creation/disposal. Fixes a possible concurrency issue when translating a call in jigasi and the xmpp and sip call end up with different translators. * Skips reconnecting removed providers. If connection failed event and removing an account happen at the same time, the thread for undrigister&reconnect can put a PP instance in currentlyReconnecting, while the provider is removed and we no longer need to reconnect it. * Simplifies logic and reverts c920e8c as it breaks other connect cases. c920e8c breaks the case when we are trying to connect a server which is not available at the moment and we never retry. This also reverts the change about executing unregister in new thread, which was due to ICQ producing regStatechange event from getStateChange, as this behaviour was fixed/changed in e625b43. That change also fixes the concurrency issue between connection failed and remove account, as without the thread the two operations are well synchronized. * Moves all resource not found messages to debug level. * Update OSGi after Re-architecting. (jitsi#629) * AppIndicator: Update OSGi after Re-architecting. AppIndicator uses org/jitsi/utils/logging/Logger. Therefore, when enabled via Menu » Tools » Options » General » Tray implementation, a NoClassDefFoundError was thrown at the start of Jitsi Desktop. * AppIndicator: Update OSGi after Re-architecting. LoginByClientCertificateStrategy uses org/jitsi/utils/logging/Logger. * DemuxContactSource: Update OSGi after Re-architecting. DemuxContactSource uses org/jitsi/utils/StringUtils and org/jitsi/utils/logging/Logger. As a side effect, the line-ending of the whole file got normalized. * JdbcConfigService: Update OSGi after Re-architecting. JdbcConfigService uses org/jitsi/utils/StringUtils. * DNS: Update OSGi after Re-architecting. ConfigurableDnssecResolver uses org/jitsi/utils/StringUtils. DnsUtilActivator uses org/jitsi/utils/StringUtils. * CertConfigEntryDialog: Update OSGi after Re-architecting. CertConfigEntryDialog uses org/jitsi/utils/StringUtils. * PhoneNumberContactQuery: Update OSGi after Re-architecting. PhoneNumberContactQuery uses org/jitsi/utils/StringUtils. * BusyLampField: Update OSGi after Re-architecting. BLFContactSourceService uses org/jitsi/utils/StringUtils. * AccountInfo: Update OSGi after Re-architecting. AccountDetailsPanel uses org/jitsi/utils/StringUtils. * HttpUtil: Update OSGi after Re-architecting. HttpUtils uses org/jitsi/utils/StringUtils. * Refactor reconnect plugin. (jitsi#636) * Refactor reconnect plugin. Now we have a registration state listener per provider in the wrapper. If there is some locking or slowness it will not affect all providers. Minimizes the synchronized blocks and make them per provider. * Renames a method. * Moves timer and ReconnectTask in the wrapper. This way we will have more rapid reconnects as there will be a thread for every reconnect task, and not a single one for all tasks. * Adds back the logs for info and debug. * Removes duplicate method. * No need of an extra thread as we have now Timer per connection. * Apache Felix (OSGi): Allow X11 to the Java Classloader. Otherwise, sometimes (not reproducible), JAWT Rendering is not able to load the class sun.awt.x11.XErrorHandlerUtil. Requires the latest LibJitsi, see jitsi/libjitsi#514. * Updates debian dependencies. (jitsi#620) * Updates debian dependencies. required for Ubuntu 18.10, Ubuntu 19.04, and Ubuntu 19.10 already * Updates debian dependencies. required for Debian 10 (Buster), Ubuntu 18.10, Ubuntu 19.04, and Ubuntu 19.10 already * Debian: Depend on FFmpeg and AppIndicator optionally. - AppIndicator is enabled optionally via Menu » Tools » Options » General » Tray implementation. - FFmpeg is used for video and the audio codec AMR-WB (therefore, libavcodec-extra preferred). Jitsi Desktop runs without those. Furthermore, Jitsi changed to Java 8 as minimum, which is reflected here now. * Debian: Depend on FFmpeg and AppIndicator optionally. - AppIndicator is enabled optionally via Menu » Tools » Options » General » Tray implementation. - FFmpeg is used for video and the audio codec AMR-WB (therefore, libavcodec-extra preferred). - jitsi-archive-keyring was used so updates do not break while transitioning to a newer Debian repository. Jitsi Desktop runs without those. Furthermore, Jitsi changed to Java 8 as minimum, which is reflected here now. * Update control.tmpl * Fixes possible NPE when receiving a message while joining. We can receive a message before the nickname is set. * Updates to latest libjitsi, jitsi-lgpl-dependencies and jitsi-utils. * Add support to send JSON using SIP INFO and handle startmuted (jitsi#646) * Add support to send JSON using SIP INFO and handle startmuted * Remove processResponse and add requestHandled flag. * Minimizes sync block trying to fix a deadlock. (jitsi#650) "qtp802921335-29": at net.java.sip.communicator.plugin.reconnectplugin.PPReconnectWrapper.registrationStateChanged(PPReconnectWrapper.java:148) - waiting to lock <0x000000070068f518> (a java.lang.Object) at net.java.sip.communicator.service.protocol.AbstractProtocolProviderService.fireRegistrationStateChanged(AbstractProtocolProviderService.java:187) at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.unregisterInternal(ProtocolProviderServiceJabberImpl.java:1574) - locked <0x0000000700267760> (a java.lang.Object) at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.unregister(ProtocolProviderServiceJabberImpl.java:1536) at org.jitsi.jigasi.xmpp.CallControlMucActivator.removeCallControlMucAccount(CallControlMucActivator.java:494) - locked <0x0000000700486e80> (a java.lang.Class for org.jitsi.jigasi.xmpp.CallControlMucActivator) at org.jitsi.jigasi.rest.HandlerImpl.doHandleConfigureMucRequest(HandlerImpl.java:463) at org.jitsi.jigasi.rest.HandlerImpl.handleJSON(HandlerImpl.java:267) at org.jitsi.rest.AbstractJSONHandler.handle(AbstractJSONHandler.java:337) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132) at org.eclipse.jetty.server.Server.handle(Server.java:505) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:370) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:267) at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:305) at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103) at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:333) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:310) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:168) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:126) at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:366) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:786) at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:743) at java.lang.Thread.run(Thread.java:748) "Reconnect timer p:Jabber:jigasi@auth.example.com@10.20.3.220": at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.unregisterInternal(ProtocolProviderServiceJabberImpl.java:1556) - waiting to lock <0x0000000700267760> (a java.lang.Object) at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.unregisterInternal(ProtocolProviderServiceJabberImpl.java:1545) at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.unregister(ProtocolProviderServiceJabberImpl.java:1527) at net.java.sip.communicator.plugin.reconnectplugin.PPReconnectWrapper.unregister(PPReconnectWrapper.java:367) at net.java.sip.communicator.plugin.reconnectplugin.PPReconnectWrapper.reconnect(PPReconnectWrapper.java:350) - locked <0x000000070068f518> (a java.lang.Object) at net.java.sip.communicator.plugin.reconnectplugin.PPReconnectWrapper.registrationStateChanged(PPReconnectWrapper.java:221) - locked <0x000000070068f518> (a java.lang.Object) at net.java.sip.communicator.service.protocol.AbstractProtocolProviderService.fireRegistrationStateChanged(AbstractProtocolProviderService.java:187) at net.java.sip.communicator.service.protocol.AbstractProtocolProviderService.fireRegistrationStateChanged(AbstractProtocolProviderService.java:141) at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.register(ProtocolProviderServiceJabberImpl.java:532) - locked <0x0000000700268358> (a java.lang.Object) at net.java.sip.communicator.plugin.reconnectplugin.PPReconnectWrapper$ReconnectTask.run(PPReconnectWrapper.java:454) at java.util.TimerThread.mainLoop(Timer.java:555) at java.util.TimerThread.run(Timer.java:505) Found 1 deadlock. * Fixes maven build. * Add commons-lang3 to Maven modules, check build with GH Actions Missed in jitsi#606 and follow-up to d9d575d * Add Maven build cache to build action * brand: GitHub * spelling: spellcheck * fix: Fixes hanging up incoming calls with media. * Update apache commons-compress. * Updates pcap local address to be 127.0.0.1 if not found. Makes debugging easier. * ref: Initialize smack providers on factory load. Skips registering providers on every protocol provider creation. In cases like jigasi we create and remove providers dynamically and it is not necessary to keep registering those providers. * ref: Uses SourcePacketExtension instead of duplicate MediaPresenceExtension. * Extend OperationFailedException and lobby support (jitsi#699) * Add DataObject for OperationFailedException * Handle XMPP registration exception * Add lobby jid null check Co-authored-by: Cristian Florin Ghita <cristian.ghita@8x8.com> * misc: s/Atlassian/8x8/ * feat: Adds destroy room local user event (jitsi#704) * fix: Connection my not be null, but not connected. * Add room destroyed event for local user * squash: Removes unneeded ChatRoomJabberImpl reference. Co-authored-by: Cristian Florin Ghita <cristian.ghita@8x8.com> * fix: Passes alternate muc on destroy if any. * fix: Move a stacktrace for registration required to debug prints * fix: Wrong alternate muc jid passed in event. * feat: Adds a property to CallPeer to notify for transport replace. The event is used in jigasi to inform it for migrating bridges so it can act, for now with just rejoining. * feat: Adds config to skip some jingle signalling when not needed * fix: Fixes sending last seen presence. Removing the <x> extension that indicates joining and would trigger the server sending all presences and chat history. Updates the stanza id with new value before sending it. * Update Slovak translation * Fixes sometimes missing last presence for ChatRoom members. * removed redundant check for peer state Co-authored-by: Ingo Bauersachs <ingo@jitsi.org> Co-authored-by: Boris Grozev <boris@jitsi.org> Co-authored-by: damencho <damencho@jitsi.org> Co-authored-by: Oleksandr Pikozh <o.pikozh@users.noreply.github.com> Co-authored-by: brian baldino <bbaldino@gmail.com> Co-authored-by: Ivanov_DM <dmitrii-88@yandex.ru> Co-authored-by: Dmitriy S. Sinyavskiy <contact@r3code.ru> Co-authored-by: Nik Vaessen <nikvaes@gmail.com> Co-authored-by: Nik <nikvaessen@users.noreply.github.com> Co-authored-by: John Langewisch <john.langewisch@pgi.com> Co-authored-by: Praveen Gupta <pvgupta24@gmail.com> Co-authored-by: George Politis <gp@jitsi.org> Co-authored-by: Guus der Kinderen <guus.der.kinderen@gmail.com> Co-authored-by: Dmitry A <adjiev.dmitry@gmail.com> Co-authored-by: alex kuznetsov <alex.kuznetsoff@gmail.com> Co-authored-by: Dmitry Adzhiev <dmitry.adjiev@gmail.com> Co-authored-by: Yura Yaroshevich <yura.yaroshevich@gmail.com> Co-authored-by: Saúl Ibarra Corretgé <s@saghul.net> Co-authored-by: paweldomas <pawel.domas@jitsi.org> Co-authored-by: Alexander Traud <pabstraud@compuserve.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: theunafraid <ghitaflorincristian@gmail.com> Co-authored-by: Cristian Florin Ghita <cristian.ghita@8x8.com> Co-authored-by: Jose Riha <jose1711@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here in UriHandlerJabberImpl.java#332 wrong regex is used here. It allows only to run jitsi call with domain-like server address. We tried to use an IP address as domain and it fails with "Wrong contact id :".
Try to call user@localhost.local and you will succeed. Try to call user@192.168.0.1 and you will get an error "Wrong contact id : user@192.168.0.1" .
If you add a contact through GUI it allows you to add such address.
It might be fixed by changing the regexp to
.+@.+(\\.[a-z]+)?or more general.+@.+.The text was updated successfully, but these errors were encountered: