New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds json message extension #495

Merged
merged 4 commits into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@pvgupta24

pvgupta24 commented Jun 16, 2018

No description provided.

@nikvaessen

This comment has been minimized.

Show comment
Hide comment
@nikvaessen

nikvaessen Jun 16, 2018

Contributor

You should probably make a new branch based on jitsi:smack4-2 and cherry pick your commit on top if it to prevent merge conflicts and prevent other commits from showing up in the changes.

Contributor

nikvaessen commented Jun 16, 2018

You should probably make a new branch based on jitsi:smack4-2 and cherry pick your commit on top if it to prevent merge conflicts and prevent other commits from showing up in the changes.

Adds json message extension
(cherry picked from commit 149921d)

@pvgupta24 pvgupta24 changed the title from WIP : Adds json message extension to Adds json message extension Jun 21, 2018

@nikvaessen

This comment has been minimized.

Show comment
Hide comment
@nikvaessen

nikvaessen Jul 4, 2018

Contributor

LGTM, just some formatting issues.

Contributor

nikvaessen commented Jul 4, 2018

LGTM, just some formatting issues.

@bgrozev

bgrozev approved these changes Jul 9, 2018

The comments are addresses, as far as I can tell

@bgrozev bgrozev merged commit 2c8714b into jitsi:smack4-2 Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment