From 02699f47edb04e7ca3f1d61aee9eec7840bd8a8d Mon Sep 17 00:00:00 2001 From: "Maxence Dalmais (maxired)" Date: Tue, 24 Nov 2020 16:50:36 +0100 Subject: [PATCH] devicesReceived array should not be modified --- modules/RTC/RTCUtils.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/RTC/RTCUtils.js b/modules/RTC/RTCUtils.js index 01d5f9f0ee..abf0bf2778 100644 --- a/modules/RTC/RTCUtils.js +++ b/modules/RTC/RTCUtils.js @@ -664,9 +664,9 @@ function onMediaDevicesListChanged(devicesReceived) { sendDeviceListToAnalytics(availableDevices); // Used by tracks to update the real device id before the consumer of lib-jitsi-meet receives the new device list. - eventEmitter.emit(RTCEvents.DEVICE_LIST_WILL_CHANGE, devicesReceived); + eventEmitter.emit(RTCEvents.DEVICE_LIST_WILL_CHANGE, availableDevices); - eventEmitter.emit(RTCEvents.DEVICE_LIST_CHANGED, devicesReceived); + eventEmitter.emit(RTCEvents.DEVICE_LIST_CHANGED, availableDevices); } /** @@ -846,7 +846,7 @@ class RTCUtils extends Listenable { if (this.isDeviceListAvailable()) { this.enumerateDevices(ds => { - availableDevices = ds.splice(0); + availableDevices = ds.slice(0); logger.debug('Available devices: ', availableDevices); sendDeviceListToAnalytics(availableDevices);