New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the recvonly SSRC logic #380

Merged
merged 3 commits into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@paweldomas
Member

paweldomas commented Mar 3, 2017

No description provided.

Show outdated Hide outdated modules/RTC/TraceablePeerConnection.js
*/
TraceablePeerConnection.prototype.clearRecvonlySsrc = function () {
logger.info("Clearing primary video SSRC!");
this.sdpConsistency.setPrimarySsrc(undefined);

This comment has been minimized.

@bbaldino

bbaldino Mar 3, 2017

Member

there is a clearSsrcCache method for this

@bbaldino

bbaldino Mar 3, 2017

Member

there is a clearSsrcCache method for this

Show outdated Hide outdated modules/xmpp/JingleSessionPC.js
this.peerconnection.clearRecvonlySsrc();
}
// Transition from video to no video
if (oldTrack && oldTrack.isVideoTrack() && !newTrack) {

This comment has been minimized.

@bbaldino

bbaldino Mar 3, 2017

Member

wondering if it's clearer if this is an else if ?

@bbaldino

bbaldino Mar 3, 2017

Member

wondering if it's clearer if this is an else if ?

This comment has been minimized.

@paweldomas

paweldomas Mar 3, 2017

Member

not sure what kind of clarity this would add... how I personally see it that it would only make me process also the previous statement in combination with this one. Do we really have to be so picky ?

@paweldomas

paweldomas Mar 3, 2017

Member

not sure what kind of clarity this would add... how I personally see it that it would only make me process also the previous statement in combination with this one. Do we really have to be so picky ?

This comment has been minimized.

@bbaldino

bbaldino Mar 3, 2017

Member

well, using 2 if's back-to-back suggests both could be entered, but that can never happen here, right?

@bbaldino

bbaldino Mar 3, 2017

Member

well, using 2 if's back-to-back suggests both could be entered, but that can never happen here, right?

@dwilson6

This comment has been minimized.

Show comment
Hide comment
@dwilson6

dwilson6 Mar 3, 2017

Contributor

@paweldomas this PR does fix the problems I was running into.

Contributor

dwilson6 commented Mar 3, 2017

@paweldomas this PR does fix the problems I was running into.

@paweldomas

This comment has been minimized.

Show comment
Hide comment
@paweldomas

paweldomas Mar 7, 2017

Member

@bbaldino both problems should be fixed now

Member

paweldomas commented Mar 7, 2017

@bbaldino both problems should be fixed now

@bbaldino bbaldino merged commit e1b7f93 into master Mar 7, 2017

1 check passed

default 85 tests run, 0 skipped, 0 failed.
Details

@paweldomas paweldomas deleted the recvonly_ssrc branch Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment