New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also cache certificate and fingerprint in DtlsControlImpl #109

Merged
merged 1 commit into from Mar 21, 2016

Conversation

Projects
None yet
5 participants
@champtar
Contributor

champtar commented Mar 17, 2016

No reasons to compute a new cert with the same keypair

Signed-off-by: Etienne CHAMPETIER champetier.etienne@gmail.com

@jitsi-jenkins

This comment has been minimized.

Show comment
Hide comment
@jitsi-jenkins

jitsi-jenkins Mar 17, 2016

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jitsi-jenkins commented Mar 17, 2016

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@bgrozev

This comment has been minimized.

Show comment
Hide comment
@bgrozev

bgrozev Mar 17, 2016

Member

Jenkins: add to whitelist

Member

bgrozev commented Mar 17, 2016

Jenkins: add to whitelist

@champtar

This comment has been minimized.

Show comment
Hide comment
@champtar

champtar Mar 17, 2016

Contributor

@ibauersachs do you want me to also remove the leading '_'

Contributor

champtar commented Mar 17, 2016

@ibauersachs do you want me to also remove the leading '_'

@ibauersachs

This comment has been minimized.

Show comment
Hide comment
@ibauersachs
Member

ibauersachs commented Mar 17, 2016

Yes.

@lyubomir

This comment has been minimized.

Show comment
Hide comment
@lyubomir

lyubomir Mar 17, 2016

Member

@champtar & @ibauersachs, I have my own version in my local clone. May I please take over the merge of this PR?

Member

lyubomir commented Mar 17, 2016

@champtar & @ibauersachs, I have my own version in my local clone. May I please take over the merge of this PR?

@champtar

This comment has been minimized.

Show comment
Hide comment
@champtar

champtar Mar 17, 2016

Contributor

You can close this one if you think yours is better.

Contributor

champtar commented Mar 17, 2016

You can close this one if you think yours is better.

Also cache certificate and fingerprint in DtlsControlImpl
No reasons to compute a new cert with the same keypair

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
@champtar

This comment has been minimized.

Show comment
Hide comment
@champtar

champtar Mar 18, 2016

Contributor

@lyubomir i've updated the commit to remove '_'
can you merge your patch or mine?

Contributor

champtar commented Mar 18, 2016

@lyubomir i've updated the commit to remove '_'
can you merge your patch or mine?

@lyubomir lyubomir self-assigned this Mar 18, 2016

@lyubomir lyubomir merged commit c5e4006 into jitsi:master Mar 21, 2016

1 check passed

default Build finished.
Details

@champtar champtar deleted the champtar:cache branch Mar 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment