New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Long using equals and not == #140

Merged
merged 1 commit into from Apr 18, 2016

Conversation

Projects
None yet
3 participants
@champtar
Contributor

champtar commented Apr 14, 2016

Two different Long objects A and B can have the same value
giving true for A.equals(B) but false for A == B

Found using FindBugs
http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON

Signed-off-by: Etienne CHAMPETIER champetier.etienne@gmail.com

Compare Long using equals and not ==
Two different Long objects A and B can have the same value
giving true for A.equals(B) but false for A == B

Found using FindBugs
http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>

@lyubomir lyubomir self-assigned this Apr 14, 2016

@bgrozev bgrozev merged commit 52d48e3 into jitsi:master Apr 18, 2016

1 check failed

default Build finished.
Details

@champtar champtar deleted the champtar:equals_vs_== branch Apr 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment