New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for simple bugs found with FindBugs #146

Merged
merged 7 commits into from Apr 25, 2016
Commits on Apr 21, 2016
  1. AudioNotifierServiceImpl: prevent ClassCastException in equals

    champtar committed Apr 15, 2016
    instanceof also check for null
    http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS
    
    Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
  2. Fix copy/paste error

    champtar committed Apr 15, 2016
    Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
  3. Remove dead code

    champtar committed Apr 15, 2016
    Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
  4. Do not use integral division

    champtar committed Apr 15, 2016
    http://findbugs.sourceforge.net/bugDescriptions.html#ICAST_IDIV_CAST_TO_DOUBLE
    
    Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
  5. Avoid multiplication overflow in SKP_SMLALBB

    champtar committed Apr 15, 2016
    http://findbugs.sourceforge.net/bugDescriptions.html#ICAST_INTEGER_MULTIPLY_CAST_TO_LONG
    
    Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
  6. Close InputStream from getSystemResourceAsStream()

    champtar committed Apr 15, 2016
    Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>