New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework getRoundTripDelay to reduce 'RTT computation may be wrong' #152

Merged
merged 1 commit into from Apr 25, 2016

Conversation

Projects
None yet
2 participants
@champtar
Contributor

champtar commented Apr 25, 2016

If RTT is really small (<1ms, like in a test setup), we might
end up with negative ntprtd value, but less than 1ms, which
we can round to 0. This is normal because timeMs is System.currentTimeMillis(),
so the (im)precision is 1ms at best.

Signed-off-by: Etienne CHAMPETIER champetier.etienne@gmail.com

Rework getRoundTripDelay to reduce 'RTT computation may be wrong'
If RTT is really small (<1ms, like in a test setup), we might
end up with negative ntprtd value, but less than 1ms, which
we can round to 0. This is normal because timeMs is System.currentTimeMillis(),
so the (im)precision is 1ms at best.

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
@bgrozev

This comment has been minimized.

Show comment
Hide comment
@bgrozev

bgrozev Apr 25, 2016

Member

This has been bugging us for a while. Thank you, @champtar!

Member

bgrozev commented Apr 25, 2016

This has been bugging us for a while. Thank you, @champtar!

@bgrozev bgrozev merged commit 5927396 into jitsi:master Apr 25, 2016

1 check passed

default Build finished.
Details

@champtar champtar deleted the champtar:rtt branch Apr 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment