Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use concrete type in itemWithLabel instead of id #22

Merged
merged 3 commits into from Nov 28, 2012

Conversation

Projects
None yet
2 participants
Contributor

pburleson commented Nov 28, 2012

If something else in a project has an object with a label property and that class is ahead of RIButton in the imports, the compiler gives a warning that setLabel: is possibly receiving the wrong type.

Switching to the concrete RIButtonItem type clears this warning. There should be no adverse impact that I'm aware of.

pburleson added some commits Dec 6, 2011

Fix crash if tap outside popover of UIActionSheet dismisses it withou…
…t selection. If presented from a UIBarButtonItem and a tap away dismisses the sheet's popover, the buttonIndex is -1 causing an index out of bounds exception.
Merge in changes from Jiva's master repo
Bring our fork up-to-date
Use concrete type in itemWithLabel instead of id
If something else in a project has an object with a label property and that class is ahead of RIButton in the imports, the compiler gives a warning that setLabel: is possibly receiving the wrong type.

Switching to the concrete RIButtonItem type clears this warning. There should be no adverse impact that I'm aware of.

jivadevoe added a commit that referenced this pull request Nov 28, 2012

Merge pull request #22 from martiancraft/master
Use concrete type in itemWithLabel instead of id

@jivadevoe jivadevoe merged commit a3183f2 into jivadevoe:master Nov 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment