Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

sfmt_pure_tests: add value tests for init_gen_rand/gen_rand32 #8

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

gebi commented May 29, 2012

This unit tests correctly fail on 0.8.1_RELEASE sfmt_pure which
incorrectly seed the sfmt state through callchain init_gen_rand/1 and
gen_rand32/1.
From version 0.8.2_RELEASE onward those additionally unit tests
execute successfully because the wrong seeding behaviour from
sfmt_pure was fixed.

@gebi gebi sfmt_pure_tests: add value tests for init_gen_rand/gen_rand32
This unit tests correctly fail on 0.8.1_RELEASE sfmt_pure which
incorrectly seed the sfmt state through callchain init_gen_rand/1 and
gen_rand32/1.
From version 0.8.2_RELEASE onward those additionally unit tests
execute successfully because the wrong seeding behaviour from
sfmt_pure was fixed.
f4c461e

jj1bdx commented on f4c461e May 30, 2012

I was also thinking something like this commit should be added to not only for sfmt_pure but the other 5 test modules. I'll take a look at this soon.

Owner

gebi replied May 30, 2012

ACK, effectively all seed routines should be tested against all random generating routines in all modules.

@ghost ghost assigned jj1bdx May 30, 2012

Owner

jj1bdx commented Jun 1, 2012

I have to work on other tasks for a few days. I'll take a look at this again.

Contributor

gebi commented Jun 2, 2012

thx for looking into this!

Owner

jj1bdx commented Jul 8, 2012

This has been committed to the dev branch manually. Thanks!
f60a2a3

@jj1bdx jj1bdx closed this Jul 8, 2012

@jj1bdx jj1bdx added the bug label Apr 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment