Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vectors? #20

Closed
hadley opened this issue Jul 23, 2019 · 2 comments
Closed

Support vectors? #20

hadley opened this issue Jul 23, 2019 · 2 comments
Labels

Comments

@hadley
Copy link

@hadley hadley commented Jul 23, 2019

It would be useful if this worked:

x <- rnorm(100)
roll::roll_mean(x, 5)
#> Error in roll::roll_mean(x, 5): Not a matrix.

Created on 2019-07-23 by the reprex package (v0.3.0)

@jjf234 jjf234 added the enhancement label Jul 26, 2019
@jjf234
Copy link
Owner

@jjf234 jjf234 commented Aug 29, 2019

Sorry about the delay. For an update, I have added vector support to roll_mean and will implement for the other functions too.

jjf234 referenced this issue Sep 3, 2019
@jjf234
Copy link
Owner

@jjf234 jjf234 commented Sep 12, 2019

I have added vector support for each function in the development version. The reprex works as expected now:

# devtools::install_github("jjf234/roll")

x <- rnorm(100)
roll::roll_mean(x, 5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.