New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with WooCommerce admin columns #12

Closed
indrek-k opened this Issue Jun 23, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@indrek-k
Copy link

indrek-k commented Jun 23, 2017

Using PostTypes on WooCommerce 'product' post type seems to create duplicate Product Category and Product Type admin column values.

Repro:

  1. Install WooCommerce
  2. Import dummy data
  3. new PostType('product');
  4. Have a look at the Products admin table

Expected result:
admincols2

Actual result:
admincols

Workaround:

<?php

    $product->columns()->populate('product_cat', function() {
       // do nothing
    });

    $product->columns()->populate('product_type', function() {
        // do nothing
    });

I'm pretty sure this doesn't really qualify as a 'bug'. However, it took me a while to figure out what's going on while developing a bigger ecommerce site. Could we perhaps add a note to the documentation about this?

Thanks for this excellent library!

@jjgrainger

This comment has been minimized.

Copy link
Owner

jjgrainger commented Jun 26, 2017

@indrek-k Thanks for this, I will investigate :)

@jjgrainger

This comment has been minimized.

Copy link
Owner

jjgrainger commented Aug 2, 2017

I think this is related to #13

@jjgrainger jjgrainger added the Type: Bug label Aug 2, 2017

@jjgrainger jjgrainger referenced this issue Oct 24, 2017

Merged

v2.0 #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment