Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upproblem registering same taxonomy for different post type #6
Comments
This comment has been minimized.
This comment has been minimized.
Thanks for pointing this out, I'll get to fixing this as soon as I can :) |
This comment has been minimized.
This comment has been minimized.
I can confirm this problem --in fact trying to attach an existing taxonomy like |
This comment has been minimized.
This comment has been minimized.
cedarstay
commented
Apr 26, 2017
Can confirm that I am also experiencing this issue |
jjgrainger
closed this
in
e965efe
Apr 28, 2017
This comment has been minimized.
This comment has been minimized.
Hi @cedarstay @MWDelaney and @webgrafia, Just thought I'd let you know this has been fixed now. :) The I've updated the code so the taxonomy names and options are saved. Then the checks and registration of the taxonomies are run at the correct points in the WordPress event flow. Thanks everyone |
webgrafia commentedFeb 2, 2017
Hi, I love your tool, but in this version there's a problem when registering the same custom taxonomy for different post type.
example:
I think the problem is in
if (taxonomy_exists($names['name'])) { $this->existingTaxonomies[] = $names['name'];
in taxonomy function, it return false.
Do you experienced the same issue?