New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wp_dropdown_categories function for post filtering selectbox #19

Merged
merged 2 commits into from Mar 27, 2018

Conversation

Projects
None yet
2 participants
@jorisvm
Copy link
Contributor

jorisvm commented Jan 19, 2018

I had a project with a rather large tree of nested taxonomy terms and noticed the selectbox in your codebase does not visually display nested taxonomy terms. I changed some code to make sure nested (hierarchical) taxonomy terms are displayed nicely in the selectbox for post filtering. I used the native wp_dropdown_categories() for this. Also this change requires less code than the original code. Please consider this change.

Use wp_dropdown_categories function for post filtering selectbox
Use the wp_dropdown_categories for the taxonomy filtering. This nicely applies visual nesting to nested terms in the selectbox. Also this change requires less code than the original code.
@jjgrainger

This comment has been minimized.

Copy link
Owner

jjgrainger commented Jan 19, 2018

Thanks @jorisvm

Awesome stuff, I'll get this added this weekend 👍

Fix for search in admin after adding wp_dropdown_categories
option_none_value default value was -1 and broke the search in the admin when searching all taxonomies.

@jjgrainger jjgrainger merged commit 350ccad into jjgrainger:master Mar 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jjgrainger

This comment has been minimized.

Copy link
Owner

jjgrainger commented Mar 29, 2018

@jorisvm Thanks for submitting this pull request 👍, sorry I took so long getting it merged in.

@jorisvm jorisvm deleted the jorisvm:patch-1 branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment