New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.1.2 crashes every Django < 1.11a1 #104

Closed
audiolion opened this Issue Feb 16, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@audiolion
Copy link
Collaborator

audiolion commented Feb 16, 2017

No tests leads to problems 馃槩

The PR imports from django.urls.exceptions import NoReverseMatch from master which doesn't exist on Django 1.8

and causes the server to not even startup

1.8, 1.9, and 1.10 uses from django.core.urlresolvers import NoReverseMatch so only on 1.11a1 does the new code work

@audiolion audiolion changed the title v4.1.2 crashes on Django 1.8 v4.1.2 crashes every Django < 1.11a1 Feb 16, 2017

@jjkester jjkester added the bug label Feb 16, 2017

jjkester added a commit that referenced this issue Feb 16, 2017

@jjkester

This comment has been minimized.

Copy link
Owner

jjkester commented Feb 16, 2017

Fixed in #105. A test is still needed though, so keeping this issue open.

@jjkester

This comment has been minimized.

Copy link
Owner

jjkester commented Feb 16, 2017

0.4.3 is released, fixing this nasty bug.

@audiolion

This comment has been minimized.

Copy link
Collaborator Author

audiolion commented Feb 16, 2017

Thank you for the quick release! Agreed we need to get test for the regression/just adding a test for the mixins.py file should do the trick

@jjkester

This comment has been minimized.

Copy link
Owner

jjkester commented Feb 16, 2017

I thought just to release a fix asap so everyone can get on with their job. As I accepted the PR that caused this I thought "well, a (regression) test can always be made in case something breaks". The universe seems to have decided that this needs a test right away.

@jjkester jjkester added the fixed label Mar 1, 2017

@audiolion audiolion closed this Jun 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment